[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Improve configurability of ox-koma-letter
From: |
Alan Schmitt |
Subject: |
Re: [O] [PATCH] Improve configurability of ox-koma-letter |
Date: |
Mon, 22 Apr 2013 14:06:36 +0200 |
User-agent: |
mu4e 0.9.9.5; emacs 24.3.1 |
Viktor Rosenfeld writes:
> Hi Alan,
>
> Alan Schmitt wrote:
>
>> A couple notes about the patch:
>> - Could you create it using "git format-patch"? This way we'll have
>> more metadata in the commit.
>
> I actually did that first and liked it more because then the patch was
> split into more logical blocks (nine patches in total). However, I did
> not add correct changelog entries to the commits. Should I resend the
> individual patches nevertheless? I could add/change the commit message
> manually in the email, I suppose.
Or you could do a git rebase interactive to merge all the commits
together.
>> - I think there is an issue with the handling of signatures. I tried
>> with an old letter that uses a LCO with a graphical signature in it, but
>> it gets overridden upon export. Here is the generated TeX.
>>
>> #+BEGIN_SRC latex
>> \LoadLetterOption{InriaRennesFR}
>> \setkomavar{signature}{\usekomavar{fromname}}
>> #+END_SRC
>>
>
> Have you tried clearing the signature?
>
> #+BEGIN_SRC emacs-lisp
> (setq org-koma-letter-signature nil)
> #+END_SRC
Yes, I changed it globally and I still get the same thing. I also
tried doing a
#+BEGIN_SRC org
#+signature: ""
#+END_SRC
and it inserts it in the LaTeX file as such, after my LCO declaration.
Alan
- [O] [PATCH] Improve configurability of ox-koma-letter, Viktor Rosenfeld, 2013/04/21
- Re: [O] [PATCH] Improve configurability of ox-koma-letter, Alan Schmitt, 2013/04/22
- Re: [O] [PATCH] Improve configurability of ox-koma-letter, Nicolas Goaziou, 2013/04/22
- Re: [O] [PATCH] Improve configurability of ox-koma-letter, Alan Schmitt, 2013/04/22
- Re: [O] [PATCH] Improve configurability of ox-koma-letter, Viktor Rosenfeld, 2013/04/22
- Re: [O] [PATCH] Improve configurability of ox-koma-letter,
Alan Schmitt <=
- Re: [O] [PATCH] Improve configurability of ox-koma-letter, Viktor Rosenfeld, 2013/04/22
- Re: [O] [PATCH] Improve configurability of ox-koma-letter, Alan Schmitt, 2013/04/23
- Re: [O] [PATCH] Improve configurability of ox-koma-letter, Viktor Rosenfeld, 2013/04/23
- Re: [O] [PATCH] Improve configurability of ox-koma-letter, Alan Schmitt, 2013/04/23
- Re: [O] [PATCH] Improve configurability of ox-koma-letter, Alan Schmitt, 2013/04/23
- Re: [O] [PATCH] Improve configurability of ox-koma-letter, Viktor Rosenfeld, 2013/04/23
- Re: [O] [PATCH] Improve configurability of ox-koma-letter, Alan Schmitt, 2013/04/23
Re: [O] [PATCH] Improve configurability of ox-koma-letter, Viktor Rosenfeld, 2013/04/22
Re: [O] [PATCH] Improve configurability of ox-koma-letter, Rasmus, 2013/04/22