Re: [O] [PATCH] export to various flavors of (X)HTML

[Eric Abrahamsen]

Rick Frankel <address@hidden> writes:

> On 19.04.2013 05:57, Eric Abrahamsen wrote:
>> I'm starting a new thread for this since the previous discussion was
>> buried in with something tangential.
>
>> I'm not proud of some of the implementation (self-closing vs
>> non-self-closing tags are ugly, and I wish org-html-html5-p and
>> org-html-xhtml-p were variables, not functions), but there it is, it
>> seems to work.
>>
>> If this is deemed okay I'll send a version of the patch with a proper
>> commit message, and also updated documentation.

Thanks for looking at this!

> I disagree with the minimized closing patch change.
>
> All versions of html accept the " />" idiom (with the extra space so
> that html4 only browsers
> don't break) for minimized tags (also "></{elem}", e.g. "<hr></hr>" is,
> i believe, always valid). html5 certainly accepts valid xhtml as
> input. It would entirely break e.g, nxml-mode or xsl post-processing
> to make this change.

The " />" style doesn't validate for html4, that's what I was going on.
It certainly doesn't make my browser explode, but I wanted that little
green checkmark! If we can live with that, that's fine, or I can try to
come up with a less hacky way of handling closing tags -- a macro maybe.

> Other things that don't need to be removed for html5:
>
>    - CDATA escapes
>    - xmns: .. xml:lang declarations (as long as you keep the html
> valid xml)

I'd be happy to leave the CDATA escapes in there, since it really
doesn't seem to make any difference, and the implementation is ugly. I
think I'm erring on the side of pedantic correctness.

The xmns declaration, on the other hand, seems quite meaningless for
anything that isn't xhtml (even if it doesn't actually break), and it's
only a couple of lines of code to deal with, I'd rather keep that in
there...

Thanks again,
Eric

>
> As a positive side effect, backing out these changes would simplify
> the patch a lot :)
>
>
> The doctype (and fix to the text/javascript closing tag) changes look
> great.
>
> rick