[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH 09/10] Remove org-babel-check-confirm-evaluate macro
|
From: |
Achim Gratz |
|
Subject: |
Re: [O] [PATCH 09/10] Remove org-babel-check-confirm-evaluate macro |
|
Date: |
Tue, 02 Apr 2013 21:53:45 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Aaron Ecay writes:
> * lisp/ob-core.el (org-babel-check-confirm-evaluate): remove
> (org-babel-check-evaluate),
> (org-babel-confirm-evaluate): move logic here
>
> This macro is used in only two places, and has two almost-independent
> complex logics coded into it. So, suppress the macro and move the logic
> into the respective functions.
I have recently introduced that macro because no amount of documentation
can guarantee that the two functions using these values compute them the
same way when somebody makes further changes down the road. That is,
however, mandatory for these functions to work properly and safely.
I haven't checked if the logic hasn't changed with that patch, but I
don't think it's any easier to understand than before.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves
- Re: [O] [PATCH 07/10] Simplify org-babel-execute-src-block, (continued)
- [O] [PATCH 05/10] Remove info arg from several org-babel functions, Aaron Ecay, 2013/04/01
- [O] [PATCH 08/10] Fix testing/lisp/test-ob-emacs-lisp.el, Aaron Ecay, 2013/04/01
- [O] [PATCH 06/10] Use prefix arg in org-edit-special, Aaron Ecay, 2013/04/01
- [O] [PATCH 09/10] Remove org-babel-check-confirm-evaluate macro, Aaron Ecay, 2013/04/01
- Re: [O] [PATCH 09/10] Remove org-babel-check-confirm-evaluate macro,
Achim Gratz <=
- [O] [PATCH 10/10] Document how :var introduces code block dependencies., Aaron Ecay, 2013/04/01
- Re: [O] [PATCH 00/10] babel cleanups, Eric Schulte, 2013/04/02