[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Fix several byte-compile warnings in org-contrib files
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [PATCH] Fix several byte-compile warnings in org-contrib files |
Date: |
Mon, 01 Apr 2013 16:27:32 +0200 |
Hello,
Thanks for your patch. Here are a few comments.
Aaron Ecay <address@hidden> writes:
> +(require 'cl-lib)
This is not an option since Org has to support Emacsen older than 24.3.
> - (add (remove-if (lambda (author) (string-match "others" author))
> - (remove-duplicates (apply #'append (col :authors))
> + (add (cl-remove-if (lambda (author) (string-match "others" author))
> + (cl-remove-duplicates (apply #'append (col :authors))
> :test #'string=)))
Here, we can use `org-remove-if' and `org-uniquify'.
Regards,
--
Nicolas Goaziou
- Re: [O] [PATCH] Fix several byte-compile warnings in org-contrib files,
Nicolas Goaziou <=