emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [patch] LaTeX export using tabu tables


From: Eric Abrahamsen
Subject: Re: [O] [patch] LaTeX export using tabu tables
Date: Tue, 26 Mar 2013 10:54:04 +0800
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3 (gnu/linux)

Nicolas Goaziou <address@hidden> writes:

I'll get this right eventually...

>> +     (spread (plist-member attr :spread))
>
> I think you mean (plist-get attr :spread), otherwise ":spread nil" will
> still activate spread. Also, since it's a predicate, I suggest to name
> the variable "spreadp".

Me being clever again -- I misunderstood how that would work.


[...]

> "longtabu" gets its own cond branch, but not "tabu". I think that
> defeats the purpose of the separation, which is to be able to add
> support for features of this rich table environment without cluttering
> the rest of the code. Doing it partially isn't worth the code
> duplication it implies.
>
> IOW, either we separate both "tabu" and "longtabu" completely, or we
> separate none of them. Your call.

I've kept the separation. There was no need to duplicate all the float
environment stuff, so there's not too much extra code.

Thanks for all the pointers!

Eric

Attachment: 0001-ox-latex-Allow-use-of-the-tabu-and-longtabu-table-en.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]