emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [ANN] Merge of new export framework on Wednesday


From: Rick Frankel
Subject: Re: [O] [ANN] Merge of new export framework on Wednesday
Date: Sun, 3 Mar 2013 20:50:51 -0500
User-agent: Mutt/1.5.21 (2010-09-15)

Bastien-

On Sat, Mar 02, 2013 at 07:14:07PM +0100, Bastien wrote:
> Done.  You can now use HTML_HEAD instead of HTML_STYLE.
> 
> Some variables were also renamed, check the details here:
> http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=2752ef

In trying to migrate these changes to the slide exporters, i noticed
some confusion w/ the migration of html-style vs. html-style-extra:

-   (:html-style nil nil org-html-style)
-   (:html-style-extra "HTML_STYLE" nil org-html-style-extra newline)
-   (:html-style-include-default nil nil org-html-style-include-default)
-   (:html-style-include-scripts nil nil org-html-style-include-scripts)
+   (:html-head "HTML_HEAD" nil org-html-head newline)
+   (:html-style-include-default nil nil org-html-head-include-default-style)
+   (:html-head-include-scripts nil nil org-html-head-include-scripts)
...
-                   exp-plist :html-style-extra
-                   (concat (or (plist-get exp-plist :html-style-extra) "")
+                   exp-plist :html-head-extra
+                   (concat (or (plist-get exp-plist :html-head-extra) "")
                            "\n"
                            style)))))
Specifically,

        - :html-style was renamed to :html-head (ok), but the
        in-buffer property HTML_HEAD was added to this export
        property.

        - :html-style-extra was (which was associated w/t the
        in-buffer property HTML_STYLE) was removed from the export
        prop list (but is referenced later in the code.
        - `org-html-head-extra' is mentioned in a doc string but never
        defined.

I think this is a bug/typo. Wouldn't the following be closer to a
straight renaming:

         (:html-head nil nil org-html-head newline)
         (:html-head-extra HTML_HEAD nil org-html-head-extra newline)

or should {org-,:}html-head-extra be dropped entirely?

Also, shouldn't :html-style-include-default be
:html-head-include-default?

rick



reply via email to

[Prev in Thread] Current Thread [Next in Thread]