[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Babel support for scheme using geiser
|
From: |
Michael Gauland |
|
Subject: |
Re: [O] [PATCH] Babel support for scheme using geiser |
|
Date: |
Sat, 5 Jan 2013 18:57:51 +0000 (UTC) |
|
User-agent: |
Loom/3.14 (http://gmane.org/) |
Bastien <bzg <at> altern.org> writes:
> In the meantime, please consider adding a
> commit ChangeLog for your patch,
Most of the file has changed dramatically--would you like the changelog to list
all the functions that have been added or altered, or would a simple statement
that the file underwent a major re-write be more appropriate?
> ...avoid dangling parentheses,
Noted. That's a bad habit I've picked up somewhere (probably too many years of C
programming.)
> and don't overwrite the first line... we are in 2013
Also noted. Part of my brain refuses to acknowledge the new year until I'm back
at work. Regrettably, that won't be a problem after tomorrow.
Kind Regards,
Mike