[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Escape slashes in ARCHIVE_OLPATH
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [PATCH] Escape slashes in ARCHIVE_OLPATH |
Date: |
Fri, 09 Nov 2012 09:57:04 +0100 |
Hello,
Takafumi Arakaki <address@hidden> writes:
> Currently information about tree structure is lost if you have a slash
> in node headings. This patch fixes the problem by escaping slashes in
> headings before concatenating them.
Thanks for your patch.
Would you mind providing a test-case to illustrate the problem? Also,
could you provide a change log entry for the patch (and use git
format-patch if possible)?
> + (olpath (mapconcat
> + (lambda (s)
> + (setq s (replace-regexp-in-string "\\\\" "\\\\\\\\" s))
> + (setq s (replace-regexp-in-string "/" "\\\\/" s))
> + s)
I'd rather nest the `replace-regexp-in-string' instead of setq'ing twice
in a row the same variable. I.e:
(replace-regexp-in-string
"/" "\\\\/" (replace-regexp-in-string "\\\\" "\\\\\\\\" s))
Regards,
--
Nicolas Goaziou