[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Lookup functions, take two
From: |
Bastien |
Subject: |
Re: [O] [PATCH] Lookup functions, take two |
Date: |
Wed, 26 Sep 2012 16:26:32 +0200 |
User-agent: |
Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (gnu/linux) |
Hi Jarmo,
Jarmo Hurri <address@hidden> writes:
> I have nothing against the idea. However, I get only errors when I try
> to apply your functions in my examples. I can track down the source of
> the problems later (not today, though).
There was a typo, I attach the correct patch.
> But how about combining your idea about getting rid of CL's position
> with the following idea of building the docstring on the fly in the
> macro? That is, you do not need to define multiple functions by hand,
> but the docstrings can still be unique.
As you prefer. But C-h f will not point to org-table.el if we use this
macro. This is acceptable, but we need to mention `org-lookup' as the
"matrix" function in the docstring, so that user C-h f'ing org-lookup
will find it in org-table.el.
Another wish style-wise: the first sentence of the docstring should be
one line long. See the short parameters names and the docstrings in my
patch to get an idea -- but please feel free to also follow your taste
here, of course.
Thanks!
org-table.el.patch
Description: Text Data
--
Bastien
- Re: [O] [PATCH] Lookup functions, take two, (continued)
- Re: [O] [PATCH] Lookup functions, take two, Dominik, Carsten, 2012/09/25
- Re: [O] [PATCH] Lookup functions, take two, Bastien, 2012/09/25
- Re: [O] [PATCH] Lookup functions, take two, Jarmo Hurri, 2012/09/26
- Re: [O] [PATCH] Lookup functions, take two, Bastien, 2012/09/26
Re: [O] [PATCH] Lookup functions, take two, Achim Gratz, 2012/09/25