[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Don't force the <style> tag to be present in `org-agenda

From: Sebastien Vauban
Subject: Re: [O] [PATCH] Don't force the <style> tag to be present in `org-agenda-export-html-style'
Date: Wed, 19 Sep 2012 20:54:01 +0200
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2 (windows-nt)

Hi Bastien,

Bastien wrote:
> thanks for the patch.
> matching against "<style>" is wrong, but matching against "style" 
> looks still useful to me.  
> What do you think?

I don't think so. Let me re-explain...

I want a correct HTML header, with a link to an external CSS file, such as:

--8<---------------cut here---------------start------------->8---
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN">
<!-- Created by htmlize-1.36 in css mode. -->
    <title>Summary Review - Aviva ETE</title>
    <link rel="stylesheet" type="text/css" href="org-agenda-views.css"/>
--8<---------------cut here---------------end--------------->8---

If I set the variable `org-agenda-export-html-style' to the string I want:

#+begin_src emacs-lisp
(setq org-agenda-export-html-style
   "<link rel=\"stylesheet\" type=\"text/css\" href=\"org-agenda-views.css\"/>")

it will be *ignored*... because there is no word `style' (with or without the
angular brackets)!

I don't understand /why such a test was made/, but clearly (with the above
example), we can't force the user to wrap the <link/> inside <style> tags;
otherwise, the browser does not look for the external CSS file.

The only solution is:
- don't check for `style'
- allow a pure `link' tag to be inserted in the header

what my patch does.

Best regards,

Sebastien Vauban

reply via email to

[Prev in Thread] Current Thread [Next in Thread]