emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH v2 00/11] Takjuggler exporter improvements


From: Bastien
Subject: Re: [O] [PATCH v2 00/11] Takjuggler exporter improvements
Date: Thu, 16 Aug 2012 09:48:25 +0200
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux)

Hi Yann,

Yann Hodique <address@hidden> writes:

> here is a new version of the patch series.

Thanks.

> Changes are:
>
> - fixed commit messages format

Thanks for this effort -- not nitpicking, but there is room left for
small improvements.

- The summary line should be "org-taskjuggler.el: Sentence" (note the
  .el after "org-taskjuggler").

- The ChangeLog entries should be sentences, starting with an uppercase
  letter and ending with a full stop.

- It should be filled with C-x f 72 (or 70) then M-q.

- "Interactive functions" = "commands"
  "custom variables" = "options"
  
  This makes the entries shorter and tells immediatly what it is about.

All this because those entries are later on automatically parsed to get
added to Emacs.  I review them manually, but fixing lots of entries
manually take a lot of time.

I'm having a branch with your changes -- I'll apply it when you confirm
you received the FSF papers.

Thanks!

-- 
 Bastien



reply via email to

[Prev in Thread] Current Thread [Next in Thread]