emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] make test on Mac


From: Eric Schulte
Subject: Re: [O] make test on Mac
Date: Wed, 01 Aug 2012 09:35:52 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)

Bastien <address@hidden> writes:

> Eric Schulte <address@hidden> writes:
>
>> Bastien <address@hidden> writes:
>>
>>> Eric Schulte <address@hidden> writes:
>>>
>>>> Hmm, these tests should only be run if the "gfortran" executable is in
>>>> your path.  
>>>
>>> So let's take them out of the test suite when gfortran is not present?
>>
>> That is what we do currently, or at least that is what we're supposed to
>> be doing currently...  From the top of test-ob-fortran.el
>>
>>     ;; -*- emacs-lisp -*-
>>     (org-test-for-executable "gfortran")
>>     (unless (featurep 'ob-fortran)
>>       (signal 'missing-test-dependency "Support for Fortran code blocks"))
>
> Maybe this should be 
>
>     (unless (and (org-test-for-executable "gfortran") (featurep 'ob-fortran))
>       (signal 'missing-test-dependency "Support for Fortran code blocks"))
>
> ?
>
> to also ignore the test when gfortran does not exist?  Wild guess.

Nope, `org-test-for-executable' signals it's own error, but if we
changed `org-test-for-executable' to return a boolean and then used your
example above it would be more readable.

Best,

-- 
Eric Schulte
http://cs.unm.edu/~eschulte



reply via email to

[Prev in Thread] Current Thread [Next in Thread]