[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] fix hook calling in org-export-remove-or-extract-drawers
From: |
Bastien |
Subject: |
Re: [O] [PATCH] fix hook calling in org-export-remove-or-extract-drawers |
Date: |
Tue, 01 May 2012 12:01:08 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) |
Hi Bill,
Thanks for the patch. Please don't attach patches using
application/octet-stream, patchwork don't catch those -- see
http://orgmode.org/worg/org-contribute.html#sec-4-3
Bill Wishon <address@hidden> writes:
> * lisp/org-exp.el (org-export-remove-or-extract-drawers): Changed
> funcall to run-hook-with-args-until-success to properly run the
> org-export-format-drawer-function hook.
>
> The problem was that funcall was being executed on the hook (list of
> functions) instead of running the hook with
> run-hook-with-args-until-success, which tries to run potentially a
> list of hooks until one returns non-nil.
I don't really understand why `run-hook-with-args-until-success' is
needed here. Or `org-export-format-drawer-function' returns a string,
or it returns nil, in case we fall back on `org-export-format-drawer'.
Maybe I miss something?
--
Bastien
- Re: [O] [PATCH] fix hook calling in org-export-remove-or-extract-drawers,
Bastien <=