[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Escape link path only if path contains space or non-asci
From: |
Bastien |
Subject: |
Re: [O] [PATCH] Escape link path only if path contains space or non-ascii character |
Date: |
Tue, 20 Dec 2011 23:54:56 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) |
Hi David,
David Maus <address@hidden> writes:
> Attached patch should take care of mistakenly double-escaped links as
> reported by Jeff Horn in <http://article.gmane.org/gmane.emacs.orgmode/48731>.
>
> This patch might break `org-open-at-point' for some users if the
> target application does not deal with (possibly) unescaped URLs. The
> alternative to the guesswork would require parsing und analyzing the
> link and its components (path, query, fragment) and check for
> characters that absolutely need escaping depeding on the link type.
>
> Hopefully this solution is good enough.
Guessing is probably safe here -- tests will tell. Thanks for
following this issue so closely and thanks for the patch! I've
now applied it.
Best,
--
Bastien