emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH]: New Add defun org-mode-or-derived-mode-p


From: Bastien
Subject: Re: [O] [PATCH]: New Add defun org-mode-or-derived-mode-p
Date: Sat, 22 Oct 2011 11:31:21 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux)

Hi Tassilo,

Tassilo Horn <address@hidden> writes:

> Ups, I've slightly misread your suggestion.  Currently, there is only
> one place in org-src.el that check for being a mode derived from
> org-mode or org-mode itself.  The second is useless, because
> (derived-mode-p 'org-mode) is true for org-mode, too.
>
> But as I've said, I've misread your suggestion and made a patch that
> completely erases org-mode-p and all its calls.  Feel free to apply or
> discard it. :-)

I applied this patch -- thanks for it.

IMHO another reason for using (eq major-mode 'org-mode) instead of
(org-mode-p) is that new contributors are likely to use this more
explicit (though longer) expression before they find out that a 
defsubst is available for that.

-- 
 Bastien



reply via email to

[Prev in Thread] Current Thread [Next in Thread]