emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] FYI: Org mode testing framework, Emacs 23 and 22


From: David Maus
Subject: Re: [O] FYI: Org mode testing framework, Emacs 23 and 22
Date: Sun, 18 Sep 2011 16:46:31 +0200
User-agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/23.2 (i486-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)

At Sat, 17 Sep 2011 14:56:09 -0600,
Eric Schulte wrote:
> 
> Hi David,
> 
> >
> > For Emacs22 the only thing we need from simple.el is the definition of
> > special-mode; going to factor it out and trim it to Emacs22.
> >
> 
> Sounds great, thanks.
> 
> >
> > With HEAD at dbf0e6d5bcbe94c8ee57d68889d3c25bf9cdef55 and a fix for
> > the check for featurep 'org (37db5deea5ef75186bb7413b196fa0c96e5bdfb9)
> > I got:
> >
> 
> Thanks for compiling this information.
> 
> >
> >
> > Selector: "\\(org\\|ob\\)"
> > Passed: 99
> > Failed: 10 (10 unexpected)
> > Total:  109/109
> >
> > Started at:   2011-09-16 06:56:59+0200
> > Finished.
> > Finished at:  2011-09-16 06:57:04+0200
> >
> > ......FF...................................................FF..F.F.......FF.................F..............F.
> >
> > F ob-fortran/list-var
> >     Test real array input
> >     (void-function characterp)
> >
> > F ob-fortran/list-var-from-table
> >     Test real array from a table
> >     (void-function characterp)
> >
> 
> I've replaced the use of `characterp' in ob-fortran with integerp, which
> should be backwards-compatible with emacs22.
> 
> >
> > F test-ob-exp/org-babel-exp-src-blocks/w-no-file
> >     Testing export from buffers which are not visiting any file.
> >     (wrong-type-argument stringp nil)
> >
> > F test-ob-exp/org-babel-exp-src-blocks/w-no-headers
> >     Testing export without any headlines in the org-mode file.
> >     (wrong-type-argument stringp nil)
> >
> > F test-ob-lob/export-lob-lines
> >     Test the export of a variety of library babel call lines.
> >     (wrong-type-argument stringp nil)
> >
> 
> I have no idea what could be going wrong with these executions, would it
> be difficult to generate backtraces for these failures?
> 
> >
> > F test-ob-sh/dont-error-on-empty-results
> >     Was throwing an elisp error when shell blocks threw errors and
> >     (void-function org-babel-execute:sh)
> >
> > F test-org-babel/inline-src-blocks
> >     (error "No org-babel-execute function for sh!")
> >
> > F test-org-babel/inline-src_blk-default-results-replace-line-1
> >     (error "No org-babel-execute function for sh!")
> >
> 
> It looks like you need to load ob-sh.el.
> 
> >
> > F test-org-exp/stripping-commas
> >     Test the stripping of commas from within blocks during export.
> >     (wrong-type-argument stringp nil)
> >
> > F test-org/org-link-unescape-ascii-extended-char
> >     Unescape old style percent escaped character.
> >     (ert-test-failed
> >      ((should
> >        (string= "àâçèéêîôùû"
> >             (org-link-unescape "%E0%E2%E7%E8%E9%EA%EE%F4%F9%FB")))
> >       :form
> >       (string= "àâçèéêîôùû" "\340\342\347\350\351\352\356\364\371\373")
> >       :value nil))
> >
> 
> Hmm, I don't know anything about possible differences in string handling
> between Emacs22 and more modern Emacsen, but I wouldn't be surprised if
> support for accented characters was less complete in Emacs22.  Perhaps
> we should just skip this test on Emacs22.

Nope, this test is fixed. Had to explicitely tell Emacs that the
expected output string is latin-1; i.e. the input is extended ASCII
which is covered by latin-1 encoding. The test failed because
org-link-unescape returned the raw byte sequence.

I am aware that there might be a problem with opening links that
contain extended ASCII characters (=Org's old escaping choice) and I'm
going to test this next. 

The test is fine, though. The expected output is a latin-1 encoded
string.

Best,
  -- David
-- 
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... address@hidden
Email..... address@hidden

Attachment: pgp8euLWlFdQv.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]