[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[O] [patch] Problem with insert anniversary agenda function (was Re: org
From: |
Eric S Fraga |
Subject: |
[O] [patch] Problem with insert anniversary agenda function (was Re: org-bbdb-anniversaries gives error 'bad sexp') |
Date: |
Thu, 16 Jun 2011 09:04:29 +0100 |
User-agent: |
Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) |
Eric S Fraga <address@hidden> writes:
> Carsten Dominik <address@hidden> writes:
>
>> On Jun 13, 2011, at 6:15 PM, Philipp Haselwarter wrote:
>>
>>> thanks, got it working now (with some fiddling).
>>>
>>> looks like `calendar-date-style' is not honored /at all/, if you don't
>>> use YYYY-MM-DD format (as stated in the org-bbdb.el header, admittedly),
>>> it just blows up in your face :)
>>
>> While I think the org-bbdb code could be made more forgiving,
>> I strongly feel that calendar-date-style is an evil variable,
>> especially if it is applied to input. One should never rely on it.
>>
>> my 5c.
>>
>> - Carsten
>
> Although I am likely to agree with you on this, any interactions with
> Emacs's diary requires working with it.
>
> This reminds me of a problem with the insert anniversary function in the
> default agenda view ("i a"). This function ignores the
> calendar-date-style and inserts dates in the american style, which of
> course means that diary entries are quietly ignored if you have
> calendar-date-style set to anything other than 'american...
>
> Not a big deal... I don't use anniversaries *that* often!
I've made a simple change (attached) to org-agenda.el which at least
considers the 'iso date style as well as european. Might not be fancy
lisp code but I think it works?
org-agenda-consider-iso-dates.patch
Description: have insert anniversary in agenda view allow for ISO calendar dates
I know I should be formatting this appropriately etc but I'm still not
very comfortable with git... too much to do, so little time. sorry.
--
: Eric S Fraga (GnuPG: 0xC89193D8FFFCF67D) in Emacs 24.0.50.1
: using Org-mode version 7.5 (release_7.5.399.g01eb.dirty)