[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Accepted] [Orgmode] Re: Bug: Jumping to a date in the agenda changes vi
From: |
Bastien Guerry |
Subject: |
[Accepted] [Orgmode] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)] |
Date: |
Tue, 1 Feb 2011 12:52:10 +0100 (CET) |
Patch 543 (http://patchwork.newartisans.com/patch/543/) is now "Accepted".
Maintainer comment: none
This relates to the following submission:
http://mid.gmane.org/%3Csa3ei8b1sbv.fsf%40cigue.easter-eggs.fr%3E
Here is the original message containing the patch:
> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Re: Bug: Jumping to a date in the agenda changes view back
> to 'day' [7.4 (release_7.4.80.g0e5e5)]
> Date: Mon, 17 Jan 2011 20:08:04 -0000
> From: Julien Danjou <address@hidden>
> X-Patchwork-Id: 543
> Message-Id: <address@hidden>
> To: Carsten Dominik <address@hidden>
> Cc: Bernt Hansen <address@hidden>, Org Mode <address@hidden>,
> Noorul Islam K M <address@hidden>
>
> On Mon, Jan 17 2011, Carsten Dominik wrote:
>
> > have you been following this thread? I think this has to do with your
> > rewrite of the dagenda span stuff. Maybe you can find out better and
> > faster that I why this goes wrong? Please read the entire thread.
>
> I've followed but not sure I understood what the bug is. But from my
> various tries, I found a bug: when pressing 'j', the current span is
> discarded.
>
> Attached is a patch that should fix that, even for future use of
> `org-agenda-list' with the span unspecified. :)
>
>
> >From 9dd2fe6650b858a4083ebc083bb8d10a0d6ac7f2 Mon Sep 17 00:00:00 2001
> From: Julien Danjou <address@hidden>
> Date: Mon, 17 Jan 2011 16:05:28 +0100
> Subject: [PATCH] Fix agenda span on date jump
>
> * org-agenda.el (org-agenda-list): Use org-agenda-current-span as a
> possible default span if it is set.
>
> Signed-off-by: Julien Danjou <address@hidden>
> ---
> lisp/org-agenda.el | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 0cd620c..0d695b5 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -3450,7 +3450,10 @@ given in `org-agenda-start-on-weekday'."
> (setq org-agenda-last-arguments (list include-all start-day span))
> (org-compile-prefix-format 'agenda)
> (org-set-sorting-strategy 'agenda)
> - (let* ((span (org-agenda-ndays-to-span (or span org-agenda-ndays
> org-agenda-span)))
> + (let* ((span (org-agenda-ndays-to-span (or span
> + org-agenda-current-span
> + org-agenda-ndays
> + org-agenda-span)))
> (today (org-today))
> (sd (or start-day today))
> (ndays (org-agenda-span-to-ndays span sd))
> --
> 1.7.2.3
>
>
- [Accepted] [Orgmode] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)],
Bastien Guerry <=
- [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)], Matt Lundin, 2011/02/04
- [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)], Julien Danjou, 2011/02/05
- [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)], Julien Danjou, 2011/02/07
- [Accepted] [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)], Bastien Guerry, 2011/02/08
- [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)], Bastien, 2011/02/09
- Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)], Carsten Dominik, 2011/02/10
- Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)], Julien Danjou, 2011/02/10
- Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)], Carsten Dominik, 2011/02/10
- Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)], Julien Danjou, 2011/02/10
- Re: [Orgmode] Re: [Accepted] Re: Bug: Jumping to a date in the agenda changes view back to 'day' [7.4 (release_7.4.80.g0e5e5)], Bastien, 2011/02/10