Re: [Orgmode] Re: org-indent mode not indenting free text?

[Carsten Dominik]

Hi Erik,

thank you for your persistence, and sorry that I have
not been taking the time to explain myself clearly, in
this way I have made this thread unnecessarily long.

OK, lets look at exhibit 1:

   ((and org-indent-mode
         (not (org-version-check "23.1.50" "Org Indent  
mode" :predicate)))
     (message "org-indent-mode can crash Emacs 23.1 - refusing to  
turn it on!")

This test is run when someone tries to turn
on org-indent mode.  If this is not Emacs 23.1.50 or later, org-indent
mode will not be turned on, and none of the remaining code in
org-indent.el will actually run, because the mode is never turned on.

Now, exhibit 2:

(if (and (not (fboundp 'with-silent-modifications))
         (or (< emacs-major-version 23)
             (and (= emacs-major-version 23)
                  (< emacs-minor-version 2))))
    (defmacro with-silent-modifications (&rest body)
      `(org-unmodified ,@body)))

This is code to supply a replacement macro in Emacsen where
`with-silent-modifications' was not defined.  The idea was that
maybe there are a few minor versions of Emacs where this
macro is not defined, and where org-indent-mode might still
be able to work.  Since I did not know
exactly when the macro was introduced, I put in some
version test which I now see is not very useful at all.

Is there anyone here who has Emacs 23.1.50 currently running?
Can you tell me if with-silent-modifications is defined in
"emacs -q" [1]?  If that is the case, then we can remove the
entire top-level form.

I hope I am making a bit more sense now.

Thanks



On Dec 3, 2010, at 10:21 PM, Erik Iverson wrote:

> Carsten Dominik wrote:
> > Hi Erik,
> > On Dec 3, 2010, at 5:18 PM, Erik Iverson wrote:
> > > Just a guess here: This may be some weirdness
> > > because the check in org-indent *will* allow
> > > people using GNU Emacs 23.1.50 to turn on
> > > org-indent, as far as I can tell.
> > org-indent-mode should work in 23.1.50, this is the
> > release where the fix was made.
> > > The message "org-indent-mode can crash Emacs 23.1"
> > > does not fully explain if it can also crash 23.1.50.
> > Yes, may be this is not so clear.  The current setup forbids it
> > before 23.1.50, and allows it from 23.1.50.  At least that is
> > what I meant.  Is there a bug?
>
> No, I did not realize that this is what was indeed meant.
> More below...
>
> <snip>
>
> > > > > Could you back out the change
> > > > > (most likely the defmacro for with-silent-modifications in org- 
> > > > > macs.el,
> > > > > even though I have no clue why this would interact with org- 
> > > > > indent-mode
> > > > > as it should not be defined for versions >23.1) and tell us if  
> > > > > that
> > > > > solves your problem (which I can't test because org-indent-mode  
> > > > > doesn't
> > > > > even start on Emacs 23.1)?
> > > > Yes it does! I commented out:
> > > > ;;(if (or (< emacs-major-version 23)
> > > > ;;    (and (<= emacs-major-version 23)
> > > > ;;         (< emacs-minor-version 2)))
> > > > ;;    (defmacro with-silent-modifications
> > > > ;;      (org-unmodified)))
> > > > and it now works correctly. Thanks a lot!
> > I have now changed the definition like this:
> > (if (and (not (fboundp 'with-silent-modifications))
> >     (or (< emacs-major-version 23)
> >         (and (= emacs-major-version 23)
> >          (< emacs-minor-version 2))))
> >    (defmacro with-silent-modifications (&rest body)
> >      `(org-unmodified ,@body)))
>
> I must admit I don't understand the above macro,
> but what I was getting at before was:
>
> It only appears defined for Emacs < 23.2,
> So in particular, 23.1.50 is 'stuck' in
> between these two version checks, and maybe
> that's causing Antti's issue?
>
> > May I ask you to pull and check if this is
> > working for you out of the box?
>
> Works for me fine on Emacs 23.2, we will see
> if it does for Antti also.