[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Accepted] [Orgmode] Re: In-buffer completion
From: |
Carsten Dominik |
Subject: |
[Accepted] [Orgmode] Re: In-buffer completion |
Date: |
Tue, 23 Nov 2010 15:12:13 +0100 (CET) |
Patch 396 (http://patchwork.newartisans.com/patch/396/) is now "Accepted".
Maintainer comment: No comment
This relates to the following submission:
http://mid.gmane.org/%3C874obblwa8.fsf%40gmail.com%3E
Here is the original message containing the patch:
> Content-Type: text/plain; charset="utf-8"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Subject: [Orgmode] Re: In-buffer completion
> Date: Sat, 20 Nov 2010 22:50:07 -0000
> From: Dan Davison <address@hidden>
> X-Patchwork-Id: 396
> Message-Id: <address@hidden>
> To: Carsten Dominik <address@hidden>
> Cc: John Wiegley <address@hidden>, Org Mode <address@hidden>
>
> Carsten Dominik <address@hidden> writes:
>
> > Dear all,
> >
> > yesterday I replaced the previous implementation of
> > in-buffer completion (M-TAB of Esc TAB) with a new
> > function making use of John Wiegleys pcomplete.el.
> > In fact, John did most of the Org-related implementation
> > already months ago - I only tied up some loose ends.
> >
> > So if you are noticing something unexpected in
> > in-buffer completion, this is the cause. There may
> > be bugs, if you find any, let me know.
> >
> > Most importantly, however, in-buffer completion is now
> > implement so much cleaner, and we can extend it if we
> > want. So if you have good ideas where in-buffer completion
> > would be useful and does not work already, lets hear it!
>
> Hi Carsten,
>
> That looks nice. Here's a few #+ keywords I notice are
> missing. (Shouldn't more of these entries have a terminal colon?)
>
> Dan
>
>
>
> >
> > Thanks to John for yet another great addition to Org mode.
> >
> > - Carsten
> >
> > _______________________________________________
> > Emacs-orgmode mailing list
> > Please use `Reply All' to send replies to the list.
> > address@hidden
> > http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
>
> diff --git a/lisp/org.el b/lisp/org.el
> index c634a6c..917a368 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -10547,9 +10547,14 @@ This function can be used in a hook."
> "BEGIN_VERSE" "END_VERSE"
> "BEGIN_CENTER" "END_CENTER"
> "BEGIN_SRC" "END_SRC"
> + "SOURCE:" "SRCNAME:" "FUNCTION:"
> + "RESULTS:"
> + "HEADER:" "HEADERS:"
> + "BABEL:"
> "CATEGORY" "COLUMNS" "PROPERTY"
> "CAPTION" "LABEL"
> "SETUPFILE"
> + "INCLUDE:"
> "BIND"
> "MACRO"))
>
>