emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Orgmode] Re: [PATCH 2/2] Fix broken CUSTOM_ID links


From: Carsten Dominik
Subject: [Orgmode] Re: [PATCH 2/2] Fix broken CUSTOM_ID links
Date: Fri, 12 Nov 2010 09:50:06 -0600

Hi Jambunata,

this looks good, However, I would like you to make a change to the patch more more clarity.

Could you please write

   (or preferred target)

instead of

   remove

as the ID to be inserted? Even though these are the same, the first version is a lot clearer.

With this change, I will accept the patch.

Thanks!

- Carsten

On Nov 8, 2010, at 7:39 AM, Jambunathan K wrote:


Carsten

On Nov 5, 2010, at 6:53 PM, Jambunathan K wrote:


Note the 'H:1' in options line. Export this to HTML. Note that
CUSTOMID
link is broken. A snippet of relevant HTML section is attached
below.

Change 'H:1' to 'H:3' note that there is no more brokenness.

Possible root cause: When headlines are turned to list 'extra- targets'
are not identified correctly.

That is correct - Org does not assign IDs or names to list items,
so it has no place to link to.  This could probably be fixed - anyone
would
like to fix this?


I am attaching a patch. Hope it does the right thing.

<tmp.org>--- before.html  2010-11-08 19:01:13.796875000 +0530
+++ after.html  2010-11-08 19:00:57.859375000 +0530
@@ -7,7 +7,7 @@
    <title>tmp</title>
<meta http-equiv="Content-Type" content="text/ html;charset=iso-8859-1"/>
    <meta name="generator" content="Org-mode"/>
-    <meta name="generated" content="2010-11-08 18:57:46 "/>
+    <meta name="generated" content="2010-11-08 18:56:05 "/>
    <meta name="author" content="Jambunathan K"/>
    <meta name="description" content=""/>
    <meta name="keywords" content=""/>
@@ -101,7 +101,7 @@
              </li>
            </ul>
            <ul>
- <li id="sec-1_1_2"><a name="sec-1_1_2" id="sec-1_1_2"></ a>Target with CUSTOMID <br/> + <li id="aabbccddeeff"><a name="sec-1_1_2" id="sec-1_1_2"></ a>Target with CUSTOMID <br/>

              <p>
                One
@@ -200,7 +200,7 @@
        <p class="author"> Author: Jambunathan K
<a href="mailto:address@hidden";>&lt;address@hidden&gt;</ a>
        </p>
-       <p class="date"> Date: 2010-11-08 18:57:46 </p>
+       <p class="date"> Date: 2010-11-08 18:56:05 </p>
        <p class="creator">HTML generated by org-mode 7.3 in emacs 23</p>
      </div>
    </div>
<0002-Fix-broken-CUSTOM_ID-links-to-outline-levels-exporte.patch>
- Carsten


(This bug is unrelated to any of the previous internal link bugs
that I
have reported)

# Input file

#+OPTIONS:   H:1

* Links
** Targets

*** Fuzzy Target

*** Target with CUSTOMID
 :PROPERTIES:
 :CUSTOM_ID: aabbccddeeff
 :END:

*** Dedicated Target
#   <<Dedicated Target>>

*** <<<Radioed Target>>>

** References

*** References to Fuzzy Target
 This is a link to [[Fuzzy Target]].

*** References to CUSTOMID links
 This link to  [[#aabbccddeeff][CUSTOMID Target]] is broken.

*** References to Dedicated Target
There is a link to nodesc [[Dedicated Target]] here. There is a link
 to [[Dedicated%20Target][Jump to Dedicated Target]] here.

*** References to Radioed Links
 This section has references to Radioed Target. One more reference
 to Radioed Target.



#+begin_src html
<!-- Headline defined here -->
<ul>
 <li id="sec-1_1_2">
   <a name="sec-1_1_2" id="sec-1_1_2">
   </a>
   Target with CUSTOMID
   <br/>
 </li>
</ul>

<!-- Headline referenced here   -->
<ul>
 <li id="sec-1_2_2">
   References to CUSTOMID links
   <br/>
   This link to
   <a href="#aabbccddeeff">
     CUSTOMID Target
   </a>
   is broken.
 </li>
</ul>
#+end_src


Jambunathan K.

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
address@hidden
http://lists.gnu.org/mailman/listinfo/emacs-orgmode




reply via email to

[Prev in Thread] Current Thread [Next in Thread]