Re: [Orgmode] [PATCH] Removed unecessary invocations of org-agenda-show.

[Matt Lundin]

Hi Carsten

Carsten Dominik <address@hidden> writes:

> On Sep 16, 2010, at 6:22 AM, Matthew Lundin wrote:
>
>> Hi Carsten,
>>
>> Carsten Dominik <address@hidden> writes:
>>
>>> On Sep 13, 2010, at 6:48 PM, Matt Lundin wrote:
>>>
>>>>
>>>> lisp/org-agenda.el (org-agenda-set-tags): Remove org-agenda-show to
>>>> prevent
>>>> disrupting windows and changing point in original buffer.
>>>> (org-agenda-set-property): Same
>>>> (org-agenda-set-effort): Same
>>>> (org-agenda-toggle-archive-tag): Same
>>>>
>>>> When setting a tag in the agenda, org-mode displays the
>>>> corresponding
>>>> entry in the original org buffer by calling org-agenda-show. This
>>>> has
>>>> the unwelcome side-effect of disrupting the current window
>>>> arrangement
>>>> and changing the position of the point in the original buffer. This
>>>> behavior is inconsistent with the that of org-agenda-todo, which
>>>> makes
>>>> all its changes "silently."
>>>
>>> I agree, but I am sure I used to have problems with something
>>> which is why this was added.
>>> Have you been running this patch for some time already?
>>> Without any problems like the agenda jumping to a wrong place in a
>>> org
>>> file or so?
>>
>> I haven't yet encountered any deleterious side effects, but I agree
>> that
>> this patch needs further consideration. I will do some additional
>> research/testing and return with a report. :)
>
> Hi Matt,
>
> any new about this patch?
>

I've looked at the code and can't see anything that org-agenda-show adds
to org-agenda-set-tags, apart from making the original buffer visible.

The function org-agenda-show calls org-agenda-goto, which grabs the
value of org-marker, jumps to the corresponding buffer and position, and
shows the next heading. The function org-agenda-set-tags does exactly
the same things in the background, except that it uses org-hd-marker
instead of org-marker.

As a point of comparison, org-agenda-todo seems to works just fine
without invoking org-agenda-show.

Unfortunately, there haven't been substantial changes to
org-agenda-set-tags since 4.12a (the beginning of the git repository),
so I can't reconstruct why the hack was added. 

I've not run into any troubles with the patch. I've tried moving
headlines around behind the agenda's back, changing multiple lines
before refreshing the agenda buffer, etc., all without issue. That's not
to say there aren't problems lurking out there somewhere; but detecting
them is beyond my abilities. :)

Best,
Matt