emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Orgmode] [PATCH] Fix dangling clocks created by org-clock-out-hook


From: Bernt Hansen
Subject: Re: [Orgmode] [PATCH] Fix dangling clocks created by org-clock-out-hook clocking in again
Date: Sun, 03 Oct 2010 17:53:01 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

Hi Carsten,

Sure - although I think my patch is already against origin/master that
is up to date.

It's available at git://git.norang.ca/org-mode.git fixup-dangling-clock

Let me know if you want the patch reposted to the mailing list.

Regards,
Bernt


Carsten Dominik <address@hidden> writes:

> Hi Bernt,
>
> I am having some problem here with the patches - could you please make
> me a new patch against the current master?
>
> Thanks!
>
> - Carsten
>
> On Oct 3, 2010, at 5:52 PM, Bernt Hansen wrote:
>
>> This is a fixup patch to commit
>> 17c71a40c6d07baae2e9cac606668683ddb3759c.  The org-clock-clocking-in
>> variable needs to be set when we are clocking out - in case the clock
>> out hook clocks-in again.  This fixes a bug that creates dangling
>> clock entries.
>> ---
>> lisp/org-clock.el |    3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
>> index 5b4b39c..c6f05fc 100644
>> --- a/lisp/org-clock.el
>> +++ b/lisp/org-clock.el
>> @@ -975,7 +975,8 @@ the clocking selection, associated with the
>> letter `d'."
>>      (move-marker org-clock-interrupted-task
>>                   (marker-position org-clock-marker)
>>                   (marker-buffer org-clock-marker))
>> -    (org-clock-out t))
>> +    (let ((org-clock-clocking-in t))
>> +      (org-clock-out t)))
>>
>>       (when (equal select '(16))
>>      ;; Mark as default clocking task
>> --
>> 1.7.3.1.50.g1e633
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Please use `Reply All' to send replies to the list.
>> address@hidden
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode



reply via email to

[Prev in Thread] Current Thread [Next in Thread]