emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Orgmode] [Patch] file protocol in HTML links


From: Carsten Dominik
Subject: Re: [Orgmode] [Patch] file protocol in HTML links
Date: Thu, 27 May 2010 10:57:41 +0200

Hi Sebastian,

can you then please make a patch that reverts the incorrect fix and installs your better version? Against the current master?

Thanks!

- Carsten

On May 26, 2010, at 11:51 AM, Sebastian Rose wrote:

Sebastian Rose <address@hidden> writes:
The appended patch removes the protocol part from link URIs, if the
protocol is file. Neccessary, to show images again and make links work.


diff --git a/lisp/org-html.el b/lisp/org-html.el
index d5f4775..8f7d0f3 100644
--- a/lisp/org-html.el
+++ b/lisp/org-html.el
@@ -640,7 +640,7 @@ MAY-INLINE-P allows inlining it as an image."
         (setq thefile
            (let
               ((str (org-export-html-format-href thefile)))
-              (if type
+              (if (and type (not (string= "file" type)))
                  (concat type ":" str)
                  str)))

Hi,


I just pulled and saw it was fixed already - but in a wrong way, I
believe. How about an absolute link URL with a different protocol like
gopher?

I think adding the protocol should be done, if the protocol is different
from that used to deliver the file which contains the link.

There's no need to add the protocol to an absolute path.



 Sebastian

_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
address@hidden
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

- Carsten






reply via email to

[Prev in Thread] Current Thread [Next in Thread]