[Orgmode] Re: [PATCH] little fixes for attachment git commiting

[Łukasz Stelmach]

David Maus <address@hidden> writes:

> Łukasz Stelmach wrote:
>>David Maus <address@hidden> writes:
>
>>> Łukasz Stelmach wrote:
>>>>The other one helps if for some reason the file one would like to add
>>>>matches an entry in a .gitignore file. I suppose no one puts anything in
>>>>the org-attach-directory by hand, so anything that goes there is by
>>>>intention.
>>>>http://github.com/steelman/steelman-org-mode/commit/8ade081fd5a331cc61f8f8a6f8cf5a92ff8881d5
>>>
[...]
>>> In addition one might explicitly include the content of attachment
>>> directories using the negating operator in .gitignore.
>>This might be a better solution indeed.
>
> Yep.  Though about it: Using the -f switch overrides any configuration
> of git a user may have made in a system wide, user or repository
> specific gitignore -- that shouldn't be turned on by default or even
> enforced in the source.

You're right, I admit. Please forget this commit. Take only the one
about xargs --no-run-if-empty

http://github.com/steelman/steelman-org-mode/commit/8dc5033d13af1d0aa6f1094a1775cc1a1ec33c67

>>I'll investigate it a little bit closer.
>
> Just an idea: Why not add hooks that are called after certain
> attachment operations (add, remove, update)?  This way we could
> decouple a (specific) use of git or even of git itself.

That's a little more hacking that I'd like to do now. Anyone?

> Some other thing: As far as I understood the source an error while
> synchronizing the attachment directory is indiciated in the "*Shell
> Command Output*" buffer and the miniprompt.  I'm not sure if this
> should be considered sufficient or not.

It's been enough for me to start investigating. It depends on how
userfriendly orgmode is supposed to be.
-- 
Miłego dnia,
Łukasz Stelmach