Re: [Orgmode] [PATCH] Headlines Prefixed with a Period in org-scan-tags, Why?

[Carsten Dominik]

I just pushed the following fix:


commit 1f576643db83156256abda93556e4bc42b9d6b29
Author: Carsten Dominik <address@hidden>
Date:   Sat Mar 21 13:51:01 2009 +0100

    Agenda: No longer indent matching sublevels by dots.

    When a tags/property match does match an entry and its sublevels,  
the
    sublevels used to be indented by dots, to indicate that the matches
    likely result from tag inheritance.  This is now no longer the
    default, but you can get it back with

       (setq org-tags-match-list-sublevels 'indented)


On Mar 19, 2009, at 6:29 PM, Peter Jones wrote:

> I'm looking at this code in org-scan-tags (org.el):
>
> (concat
> (if org-tags-match-list-sublevels
>     (make-string (1- level) ?.) "")
> (org-get-heading))
>
> Which causes items in my agenda buffer to be prefixed with a series of
> periods.  I've been looking around org.el, and org-agenda.el, and  
> don't
> see any code that relies on those periods being there.
>
> If I remove that if expression, the agenda looks the way I'd expect,
> with no noticeable consequences.
>
> Is there any reason the patch below would break something in Org?
>
> diff --git a/lisp/org.el b/lisp/org.el
> index dabf306..b19e3d1 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -9969,10 +9969,7 @@ only lines with a TODO keyword are included  
> in the output."
>              ((eq action 'agenda)
>               (setq txt (org-format-agenda-item
>                          ""
> -                        (concat
> -                         (if org-tags-match-list-sublevels
> -                             (make-string (1- level) ?.) "")
> -                         (org-get-heading))
> +                         (org-get-heading)
>                          category
>                          ;(org-get-tags-at)
>                          tags-list
>
>
> --
> Peter Jones, http://pmade.com
> pmade inc.  Louisville, CO US
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> address@hidden
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode