Re: [Orgmode] [PATCH] fast tag selection interface

[Carsten Dominik]

On Feb 16, 2009, at 1:15 AM, Christopher Suckling wrote:

> As a result of the 40 variables thread and assorted worg tutorials,  
> I'm getting a little carried away with customising my workflow.  
> Consequently, my tag list have grown to the extent that the fast  
> tags selection interface is looking rather messy.
>
> The small patch below adds the capability to create arbitrary new  
> lines, either by adding "\n" (backslash n, not a newline!) to your # 
> +TAGS: or by adding "(:newline . nil)" to org-tag-alist.
>
> So I can have something like:
>
> -----
> [a] @assorted [g] @gtd [c] @contexts
>
> [o] other [r] relevant [t] tags
>
> [m] more [f] for [d] different [p] projects
> -----

I am not convinced that this helps a lot.  Do ou really think
it is much better?

The patch looks good and complete!  Do you have a copyright
assignment with the FSF?  Not absolutely necessary for
this small a patch, but still...

- Carsten

> The patch is a very hacky cut and paste job with little  
> understanding of the surrounding code, but I don't seem to have  
> broken anything in my setup yet...
>
> Best wishes,
>
> Christopher
>
> -----
>
>         Modified lisp/org.el
> diff --git a/lisp/org.el b/lisp/org.el
> index c4cfacd..484df30 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -2066,7 +2066,8 @@ See the manual for details."
>            (cons   (string    :tag "Tag name")
>                    (character :tag "Access char"))
>            (const :tag "Start radio group" (:startgroup))
> -          (const :tag "End radio group" (:endgroup)))))
> +          (const :tag "End radio group" (:endgroup))
> +          (const :tag "New line" (:newline)))))
>
> (defvar org-file-tags nil
>   "List of tags that can be inherited by all entries in the file.
> @@ -3398,6 +3399,7 @@ means to push this value onto the list in the  
> variable.")
>             (cond
>              ((equal e "{") (push '(:startgroup) tgs))
>              ((equal e "}") (push '(:endgroup) tgs))
> +            ((equal e "\\n") (push '(:newline) tgs))
>              ((string-match (org-re "^\\([[:alnum:address@hidden)(\\(.\\))$") e)
>               (push (cons (match-string 1 e)
>                           (string-to-char (match-string 2 e)))
> @@ -3534,6 +3536,7 @@ Respect keys that are already there."
>       (cond
>        ((equal e '(:startgroup)) (push e new))
>        ((equal e '(:endgroup)) (push e new))
> +       ((equal e '(:newline)) (push e new))
>        (t
>         (setq k (car e) c2 nil)
>         (if (cdr e)
> @@ -8866,6 +8869,8 @@ Returns the new TODO keyword, or nil if no  
> state change should occur."
>            ((equal e '(:endgroup))
>             (setq ingroup nil cnt 0)
>             (insert "}\n"))
> +          ((equal e '(:newline))
> +           (insert "\n  "))
>            (t
>             (setq tg (car e) c (cdr e))
>             (if ingroup (push tg (car groups)))
> @@ -10316,6 +10321,8 @@ Returns the new tags string, or nil to not  
> change the current settings."
>          ((equal e '(:endgroup))
>           (setq ingroup nil cnt 0)
>           (insert "}\n"))
> +        ((equal e '(:newline))
> +         (insert "\n  "))
>          (t
>           (setq tg (car e) c2 nil)
>           (if (cdr e)
>
>
>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> address@hidden
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode