[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Orgmode] Re: Needless opening of threads in org-wl

From: Carsten Dominik
Subject: Re: [Orgmode] Re: Needless opening of threads in org-wl
Date: Sat, 27 Sep 2008 17:57:48 +0200

Hi Tokuya,

thanks a lot for looking into this.

Hi Dhruv,

thank you for fixing this bug.

I have pushed the corresponding fix.

- Carsten

On Sep 27, 2008, at 5:33 PM, Tokuya Kameshima wrote:

Thank you for the report.

The line of (wl-thread-open-all) is needless.  I completely forgot to
remove it.


Could you remove the line of (wl-thread-open-all) from org-wl.el and
update the git repository?


In my initial implementation of org-wl.el, `org-wl-open' was able to
jump to the message by the message number ([[wl:folder#number]]) as
well as by the message id ([[wl:folder#msgid]]).  To jump to the
message by the number, the message line had to be shown in the summary
buffer.  So I added the code to show all the message lines in the
summary buffer.

The current version of org-wl.el does not support the link with the
message number such as [[wl:folder#number]].


From: Dhruv Bansal <lasnabvurhd <at> gmail.com>
Subject: Needless opening of threads in org-wl
Newsgroups: gmane.emacs.orgmode
Date: 2008-09-20 10:05:12 GMT (5 days, 13 hours and 37 minutes ago)

I like to link to Wanderlust emails from Org Mode.  I just downloaded
the latest git version and linking to WL emails works as advertised
except that I wind up sitting for five minutes as every thread in my
13,000 message inbox is opened.  Is there a reason for this behavior?

I "fixed" the problem with the following patch which merely comments
out the command to open all the threads.  Linking emails works
perfectly fine and now I don't have to wait long at all.

diff --git a/lisp/org-wl.el b/lisp/org-wl.el
index 4fae584..58ddd31 100644
--- a/lisp/org-wl.el
+++ b/lisp/org-wl.el
@@ -135,7 +135,7 @@
        ;; in the old buffer.
        (set-buffer old-buf)
        (goto-char old-point))
-     (wl-thread-open-all)
+;     (wl-thread-open-all)
(and (wl-summary-jump-to-msg-by-message-id (org-add-angle- brackets

Just thought I'd post this in case anyone else was similarly

I'm excited about the new org version; thanks so much everyone for
helping to create such a great application!

Dhruv Bansal

Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode <at> gnu.org

Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]