Re: [Orgmode] org-bookmark.el

[Bastien]

Phil Jackson <address@hidden> writes:

> Bastien <address@hidden> writes:
>
>> In any case, this should be implemented in org.el directly.  When
>> `org-store-link' checks whether we are in dired-mode or in a buffer
>> visiting a file, then it would also check whether 'org-bookmark is
>> provided (with (featurep 'org-bookmark)...) and act accordingly if it
>> is.
>
> I don't think it needs to go into org.el does it? When org-bookmark gets
> it's turn upon `org-store-link' it should check a variable called, for
> example, `org-bookmark-check-bookmarks-first' and then if that's non-nil
> check major-mode and act accordingly. This will keep `org-store-link'
> nice and clean.

Of course, you're right.

But I doubt whether `org-bookmark-check-bookmarks-first' would be useful
here.  People using `org-bookmark.el' are likely to use it in dired-mode
and in buffer visiting files as well.  Actually, I would use it just for
that (not really for creating links from the bookmarks list.)

`org-bookmark-store-link' could just check if we are in a dired buffer,
in a buffer visiting a file, or in a bookmark list, and act accordingly.

When in dired or visiting a file, it would try to fetch a bookmark.  
If there are more than one, then it will prompt the user for the 
bookmark to use.

Tokuya, what do you think?  
Do you want to implement this?

-- 
Bastien