[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Orgmode] Bug when following a link (org-open-at-point)

From: Carsten Dominik
Subject: Re: [Orgmode] Bug when following a link (org-open-at-point)
Date: Wed, 27 Sep 2006 23:52:54 +0200

Hi Stefan,

I really love it when someone goes all the way to analyze and fix a bug.
Thank you very much, this fix will be in the next version of org-mode.

- Carsten

On Sep 27, 2006, at 11:41, Stephan Schmitt wrote:


i just downloaded org-mode 4.50 and
got an error when i tried to follow
an internal link (C-c C-o, Mouse-2).

i traced the problem back to following
function in org.el:

(defun org-file-remote-p (file)
 "Test whether FILE specifies a location on a remote system.
Return non-nil if the location is indeed remote.

For example, the filename \"/address@hidden:/foo\" specifies a location
on the system \"/address@hidden:\"."
 (cond ((fboundp 'file-remote-p)
        (file-remote-p file))
       ((fboundp 'tramp-handle-file-remote-p)
        (tramp-handle-file-remote-p file))
       ((and (boundp 'ange-ftp-name-format)
             (string-match ange-ftp-name-format file))
       (t nil)))

the third condition (string-match ange-ftp-name-format file)
tries to match a list against a string,

(defcustom ange-ftp-name-format
 '("^/\\(\\([^@/:]*\\)@\\)?\\([^@/:]*[^@/:.]\\):\\(.*\\)" . (3 2 4))
 "*Format of a fully expanded remote file name.

This is a list of the form \(REGEXP HOST USER NAME\),
where REGEXP is a regular expression matching
the full remote name, and HOST, USER, and NAME are the numbers of
parenthesized expressions in REGEXP for the components (in that order)."
 :group 'ange-ftp
 :type '(list regexp
               (integer :tag "Host group")
               (integer :tag "User group")
               (integer :tag "Name group")))

i solved the problem by changing the condition
(string-match ange-ftp-name-format file)
(string-match (car ange-ftp-name-format) file)

best regards,

Emacs-orgmode mailing list

Carsten Dominik
Sterrenkundig Instituut "Anton Pannekoek"
Universiteit van Amsterdam
Kruislaan 403
NL-1098SJ Amsterdam
phone: +31 20 525 7477

reply via email to

[Prev in Thread] Current Thread [Next in Thread]