Re: [Emacs-orgmode] org-mode + xemacs + patch

[Carsten Dominik]

Hi Greg, I have looked at you patch and taken most of it.  However, I 
have a few questions:

>  \\{org-mode-map}"
> +
> +  ;; Get rid of Outline menus, they are not needed
> +  ;; Need to do this here because define-derived-mode sets up
> +  ;; the keymap so late.
> +  (if (featurep 'xemacs)
> +      (progn
> +       (if org-noutline-p
> +           (progn
> +             (easy-menu-remove outline-mode-menu-heading)
> +             (easy-menu-remove outline-mode-menu-show)
> +             (easy-menu-remove outline-mode-menu-hide))

This assumes that the future port of noutline will use easy-menu for 
its stuff.  OK if you get your version into XEmacs, problematic 
otherwise.  I have taken it anyway, because right now it does not break 
anything.

>                         (get-char-property (1- (point)) 'invisible))
>               (beginning-of-line 2)) (setq eol (point)))
>           (outline-end-of-heading)   (setq eoh (point))
> -         (org-end-of-subtree t)     (setq eos (point))
> +         ;;(org-end-of-subtree t)     (setq eos (point))
> +         (outline-end-of-subtree)     (setq eos (point))
>           (outline-next-heading))

Why is the above change necessary?

>         (if (equal x "") (setq x "0"))
> -       (setq form (replace-match (concat "(" x ")") t t form)))
> +       ;;(setq form (replace-match (concat "(" x ")") t t form)))
> +       (setq form (replace-match x t t form)))

I guess you need this to get the value of variables directly into the 
list form.  I need the parenthesis, because fields in tables can be 
complex expressions, and in an equation precedence rule may pull this 
expression apart, which is not wanted.  We need to do this in a way 
that the parenthesis are only ignored for lisp expressions.

> +(when (featurep 'xemacs)
> +  (define-key org-mode-map 'button3   'popup-mode-menu))
> +
>  (defsubst org-table-p () (org-at-table-p))


Any other XEmacs users who object to this change?

> @@ -13772,7 +13790,8 @@
>  Only visible heading lines are considered, unless INVISIBLE-OK is 
> non-nil."
>    (if org-noutline-p
>        (outline-back-to-heading invisible-ok)
> -    (if (and (memq (char-before) '(?\n ?\r))
> +    (if (and (or (memq (char-before) '(?\n ?\r))
> +                (point-min))
>               (looking-at outline-regexp))
>         t

This one I don't understand.  Maybe you mean

    (if (and (or (bobp) (memq (char-before) '(?\n ?\r)))

????  Point-min is never nil, it is always just a number.



Thanks.

- Carsten



--
Carsten Dominik
Sterrenkundig Instituut "Anton Pannekoek"
Universiteit van Amsterdam
Kruislaan 403
NL-1098SJ Amsterdam
phone: +31 20 525 7477