Re: bug#54458: 27.2; erc-dcc-get: Re-entering top level after C stack overflow

[J.P.]

Hi Fernando,

Fernando de Morais <fernandodemorais.jf@gmail.com> writes:

> It worked great! I was able to download four packages simultaneously,
> making use of the `-t' flag, without losing control of Emacs.
>
> In fact, the loss of control still happened a few times, even using the
> flag, but for a short time and much more rarely

Hm. I'm not sure what all we can do about the stuttering. The flag
inhibits all sending, so the filter is merely appending arriving bytes
to the work buffer and flushing it whenever its size crosses some
threshold. IOW, the EAGAIN loop discussed up thread can't occur. So,
whatever's causing the intermittent loss must be related to normal,
interleaved reading by those filters.

And without more insight into what's going on precisely with your
inputs, I don't think there's a whole lot we can do beyond speculate.
So, in the end, I guess I'm just asking you to suffer the status quo on
this one.

> [...] compared to the transfer without the flag (whose loss of control
> happens in, practically, every transfer).

Right. The sans-flag thing was another dumb idea you should have been
spared. In truth, it never stood a chance (I've come to learn) because
no one has ever implemented that form of TSEND. However, I've added
detection for one form that does exist and is very much in use, at least
by KVirc folk. I've also added a slight tweak for improved interop with
WeeChat, which has its own form of turbo (called "fast mode" or
something) that only requires a final ACK.

If you're able to try these, great. If not, no worries. I'll leave them
for a bit anyhow to focus on our main initiatives. Thanks for bearing
with me all these weeks (and with ERC all these years)!

J.P.

P.S (unrelated) I've also added SSEND detection (and an -s flag) for
senders that support it (it's just TLS, really).

0000-v4-v5.diff
Description: Text Data

0001-Display-error-message-on-incomplete-ERC-DCC-transfer.patch
Description: Text Data

0002-Don-t-send-reports-in-erc-dcc-get-filter-when-nested.patch
Description: Text Data

0003-Allow-matching-against-string-values-in-erc-dcc-memb.patch
Description: Text Data

0004-Accept-turbo-param-in-erc-dcc-do-GET-command.patch
Description: Text Data

0005-Support-receiving-from-DCC-SSEND-in-erc-dcc.patch
Description: Text Data