emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/helm 0b3a419340: Ensure OVERLAY is a ref-cell


From: ELPA Syncer
Subject: [nongnu] elpa/helm 0b3a419340: Ensure OVERLAY is a ref-cell
Date: Fri, 12 Jul 2024 16:00:22 -0400 (EDT)

branch: elpa/helm
commit 0b3a41934051ae9be4b97f92115c121f9fb0352a
Author: Thierry Volpiatto <thievol@posteo.net>
Commit: Thierry Volpiatto <thievol@posteo.net>

    Ensure OVERLAY is a ref-cell
    
    This try to fix (blindly) an error happening in Emacs-31 (setting
    constant nil...).  I suspect the error comes from here but I have no
    clue yet and I wonder why the argument OVERLAY should be nil.
    The error is rare and difficult to reproduce, when it happen once, it
    doesn't happen anymore afterward.
---
 helm-core.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/helm-core.el b/helm-core.el
index ae1a2a1c79..2d0c9e23d0 100644
--- a/helm-core.el
+++ b/helm-core.el
@@ -5154,7 +5154,8 @@ without recomputing them, it should be a list of lists."
 Argument OVERLAY is a ref-cell."
   (when (and helm-dim-prompt-on-update
              ;; Avoid an empty window when coming from bookmarks.
-             (not (helm-empty-buffer-p)))
+             (not (helm-empty-buffer-p))
+             (consp overlay)) ;; Ensure OVERLAY is a ref-cell.
     (with-selected-window (minibuffer-window)
       (setcar overlay (make-overlay (minibuffer-prompt-end) (point-max)))
       (overlay-put (car overlay) 'face '(:foreground "DimGray"))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]