emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/hyperbole ed438e42be 04/11: ibut:create - Improve messa


From: ELPA Syncer
Subject: [elpa] externals/hyperbole ed438e42be 04/11: ibut:create - Improve messages and traceback gen on ibtype error
Date: Mon, 8 Jul 2024 03:58:22 -0400 (EDT)

branch: externals/hyperbole
commit ed438e42beb527dfa5cde023e8d35e38be5dfba5
Author: bw <rsw@gnu.org>
Commit: bw <rsw@gnu.org>

    ibut:create - Improve messages and traceback gen on ibtype error
---
 ChangeLog |  2 ++
 hbut.el   | 12 ++++--------
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index c9df1c77e3..80d28a64e0 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -14,6 +14,8 @@
 * hsys-org-roam.el (hsys-org-roam-tags-view, hsys-org-roam-consult-grep): 
Prompt
     whether to install needed package when not yet installed.
 
+* hbut.el (ibut:create): Improve messages and traceback generation on ibtype 
error.
+
 2024-07-06  Bob Weiner  <rsw@gnu.org>
 
 * hibtypes.el (org-id): Fix bug in older versions of Org where where
diff --git a/hbut.el b/hbut.el
index 2a2902c547..e89a9688c1 100644
--- a/hbut.el
+++ b/hbut.el
@@ -3,7 +3,7 @@
 ;; Author:       Bob Weiner
 ;;
 ;; Orig-Date:    18-Sep-91 at 02:57:09
-;; Last-Mod:      6-Jul-24 at 01:31:19 by Bob Weiner
+;; Last-Mod:      7-Jul-24 at 14:57:30 by Bob Weiner
 ;;
 ;; SPDX-License-Identifier: GPL-3.0-or-later
 ;;
@@ -1959,13 +1959,9 @@ If a new button is created, store its attributes in the 
symbol,
                           (setq itype (car types))
                           (when (condition-case err
                                     (and itype (setq args (funcall itype)))
-                                  ;; Purposely trigger another error
-                                  ;; here by sending a symbol
-                                  ;; argument to the message call
-                                  ;; below so can see the value of
-                                  ;; itype whose funcall failed above.
-                                  (error (progn (message "%S" err)
-                                                (message itype))))
+                                  (error (progn (message "%S: %S" itype err)
+                                                ;; Show full stack trace
+                                                (debug))))
                             (setq is-type itype)
                             ;; Any implicit button type check should leave 
point
                             ;; unchanged.  Trigger an error if not.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]