emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/dslide e100759664 042/230: remove extraneous slot-bound ch


From: ELPA Syncer
Subject: [nongnu] elpa/dslide e100759664 042/230: remove extraneous slot-bound checks
Date: Sun, 7 Jul 2024 19:00:14 -0400 (EDT)

branch: elpa/dslide
commit e10075966461b0d7de933c2a7837c9c4c643b59a
Author: Psionik K <73710933+psionic-k@users.noreply.github.com>
Commit: Psionik K <73710933+psionic-k@users.noreply.github.com>

    remove extraneous slot-bound checks
    
    Had an issue in a slot declaration that made me second guess the behavior
    
    Signed-off-by: Psionik K <73710933+psionic-k@users.noreply.github.com>
---
 macro-slides.el | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/macro-slides.el b/macro-slides.el
index abbce04b99..d7401d5d97 100644
--- a/macro-slides.el
+++ b/macro-slides.el
@@ -1493,8 +1493,7 @@ deck of progress was made.")
 ;; just add overlays starting from the end of items.
 
 (cl-defmethod ms-final :after ((obj ms-action-item-reveal))
-  (when-let ((overlays (and (slot-boundp obj 'overlays)
-                            (oref obj overlays))))
+  (when-let ((overlays (oref obj overlays)))
     (mapc #'delete-overlay overlays)))
 
 ;; TODO add hide / un-hide methods to the base action
@@ -1502,8 +1501,7 @@ deck of progress was made.")
   ;; The implementation has mapped all of the items into overlays, so instead 
of
   ;; calling `ms-section-next', we just use the overlay positions to walk
   ;; through the items.
-  (when-let* ((overlays (and (slot-boundp obj 'overlays)
-                             (oref obj overlays)))
+  (when-let* ((overlays (oref obj overlays))
               (first (car overlays))
               (end (overlay-end first)))
     ;; TODO We can let-bind animations false for child slides.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]