[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/dslide e100759664 042/230: remove extraneous slot-bound ch
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/dslide e100759664 042/230: remove extraneous slot-bound checks |
Date: |
Sun, 7 Jul 2024 19:00:14 -0400 (EDT) |
branch: elpa/dslide
commit e10075966461b0d7de933c2a7837c9c4c643b59a
Author: Psionik K <73710933+psionic-k@users.noreply.github.com>
Commit: Psionik K <73710933+psionic-k@users.noreply.github.com>
remove extraneous slot-bound checks
Had an issue in a slot declaration that made me second guess the behavior
Signed-off-by: Psionik K <73710933+psionic-k@users.noreply.github.com>
---
macro-slides.el | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/macro-slides.el b/macro-slides.el
index abbce04b99..d7401d5d97 100644
--- a/macro-slides.el
+++ b/macro-slides.el
@@ -1493,8 +1493,7 @@ deck of progress was made.")
;; just add overlays starting from the end of items.
(cl-defmethod ms-final :after ((obj ms-action-item-reveal))
- (when-let ((overlays (and (slot-boundp obj 'overlays)
- (oref obj overlays))))
+ (when-let ((overlays (oref obj overlays)))
(mapc #'delete-overlay overlays)))
;; TODO add hide / un-hide methods to the base action
@@ -1502,8 +1501,7 @@ deck of progress was made.")
;; The implementation has mapped all of the items into overlays, so instead
of
;; calling `ms-section-next', we just use the overlay positions to walk
;; through the items.
- (when-let* ((overlays (and (slot-boundp obj 'overlays)
- (oref obj overlays)))
+ (when-let* ((overlays (oref obj overlays))
(first (car overlays))
(end (overlay-end first)))
;; TODO We can let-bind animations false for child slides.
- [nongnu] elpa/dslide b9219d205c 023/230: typos, comments, line-noise, (continued)
- [nongnu] elpa/dslide b9219d205c 023/230: typos, comments, line-noise, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 1dbbed70f8 025/230: missing custom group & type, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 63d93ec6bf 028/230: Dead code on slide, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 9a67bc2f3e 026/230: line noise, compiler warnings, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 3e7ceb0845 024/230: missing deps, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 1d8041aba1 027/230: Sequence (slide) callbacks, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide da4e8dd412 016/230: user error instead of silent failure, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 018b39cfa5 030/230: Remove some coupling between actions and slides, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide b26e0155d8 043/230: base action is abstract, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 027ae16365 046/230: cleaning up some line noise, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide e100759664 042/230: remove extraneous slot-bound checks,
ELPA Syncer <=
- [nongnu] elpa/dslide 2fcaadcf52 040/230: whitespace and comments, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide ea60e6e53e 035/230: prevent animation timer reference from being lost, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide d66218b161 093/230: Inhibit redisplay during babel blocks, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide ff39c2f490 087/230: Display strategy, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 2aa53d8341 094/230: recenter after opening contents, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide b57afb0da4 122/230: default breadcrumb face to inherit org-level-8, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide bf99a7df69 108/230: attr_methods -> atter_ms, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide aee6f28d4c 103/230: reasonable behavior for `ms-start-from' set to 'point, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 3547b1a1a7 107/230: rearranged demo, ELPA Syncer, 2024/07/07
- [nongnu] elpa/dslide 5956b98172 132/230: :results none in babel. really wish I could let-bind this, ELPA Syncer, 2024/07/07