emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/beframe 179c95a574: Make a private function public


From: ELPA Syncer
Subject: [elpa] externals/beframe 179c95a574: Make a private function public
Date: Fri, 7 Jul 2023 00:57:36 -0400 (EDT)

branch: externals/beframe
commit 179c95a5742ed177bab1da0352dc3028f2d2905f
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Make a private function public
    
    It is better to do this for functions that are added to hooks, because
    those are anyhow used for "public" purposes: they are not limited to
    some internal operation of the package.
    
    The practical advantage for the user is that we make a promise to keep
    this function working and to document any changes to its behaviour.
---
 beframe.el | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/beframe.el b/beframe.el
index 8ec90fb343..3852334e4f 100644
--- a/beframe.el
+++ b/beframe.el
@@ -551,14 +551,14 @@ Also see the `beframe-prefix-map'."
       (progn
         (setq beframe--read-buffer-function read-buffer-function
               read-buffer-function #'beframe-read-buffer)
-        (add-hook 'after-make-frame-functions #'beframe--frame-predicate)
         (add-hook 'after-make-frame-functions beframe-rename-function)
+        (add-hook 'after-make-frame-functions #'beframe-frame-predicate)
         (add-hook 'after-make-frame-functions #'beframe-create-scratch-buffer)
         (beframe--functions-in-frames))
     (setq read-buffer-function beframe--read-buffer-function
           beframe--read-buffer-function nil)
-    (remove-hook 'after-make-frame-functions #'beframe--frame-predicate)
     (remove-hook 'after-make-frame-functions beframe-rename-function)
+    (remove-hook 'after-make-frame-functions #'beframe-frame-predicate)
     (remove-hook 'after-make-frame-functions #'beframe-create-scratch-buffer)
     (beframe--functions-in-frames :disable)))
 
@@ -655,7 +655,12 @@ Remember that this function doubles as an example for
 Use optional FRAME to test if BUF belongs to it."
   (memq buf (beframe-buffer-list frame)))
 
-(defun beframe--frame-predicate (&optional frame)
+(define-obsolete-function-alias
+  'beframe--frame-predicate
+  'beframe-frame-predicate
+  "0.4.0")
+
+(defun beframe-frame-predicate (&optional frame)
   "Set FRAME `buffer-predicate' parameter.
 If FRAME is nil, use the current frame."
   (set-frame-parameter frame 'buffer-predicate #'beframe--frame-buffer-p))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]