[elpa] externals/hyperbole 841535cf50 1/3: Remove some byte compilation warnings (#354)

[ELPA Syncer]

branch: externals/hyperbole
commit 841535cf507221278085a598a263328461d926ba
Author: Mats Lidell <mats.lidell@lidells.se>
Commit: GitHub <noreply@github.com>

    Remove some byte compilation warnings (#354)
    
    * Remove some byte compilation warnings
    
    * hui.el:
      hpath.el:
      hbut.el:
      hbdata.el: Fix single quotes in docstrings.
    
    * kotl/kview.el (kcell-view:to-label-end): Add missing point to error
        message.
    
    * hactypes.el (require): Load hsys-org for org-fold-show-context.
        (link-to-org-id-marker): Use org-fold-show-context.
        (link-to-org-id): Silence byte compile warnings when org-roam not 
loaded.
    
    * Update after review comments
---
 ChangeLog     | 12 ++++++++++++
 hactypes.el   | 10 +++++-----
 hbdata.el     | 12 ++++++------
 hbut.el       | 10 +++++-----
 hpath.el      |  4 ++--
 hui.el        |  4 ++--
 kotl/kview.el |  4 ++--
 7 files changed, 34 insertions(+), 22 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 6303b89bcc..2e0a3499c4 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,17 @@
 2023-07-01  Mats Lidell  <matsl@gnu.org>
 
+* hui.el:
+  hpath.el:
+  hbut.el:
+  hbdata.el: Fix single quotes in docstrings.
+
+* kotl/kview.el (kcell-view:to-label-end): Add missing point to error
+    message.
+
+* hactypes.el (require): Load hsys-org for org-fold-show-context.
+    (link-to-org-id-marker): Use org-fold-show-context.
+    (org-roam-id-find): declare-function.
+
 * hyperbole.el: Preload `kotl-autoloads`.  Submitted by Stefan
     Monnier. Thanks Stefan.
 
diff --git a/hactypes.el b/hactypes.el
index bf7744d347..981af765a9 100644
--- a/hactypes.el
+++ b/hactypes.el
@@ -3,7 +3,7 @@
 ;; Author:       Bob Weiner
 ;;
 ;; Orig-Date:    23-Sep-91 at 20:34:36
-;; Last-Mod:     25-Jun-23 at 13:48:01 by Bob Weiner
+;; Last-Mod:      1-Jul-23 at 23:06:38 by Mats Lidell
 ;;
 ;; SPDX-License-Identifier: GPL-3.0-or-later
 ;;
@@ -18,7 +18,7 @@
 ;;; Other required Elisp libraries
 ;;; ************************************************************************
 
-(eval-and-compile (mapc #'require '(bookmark hvar hsettings comint hbut hpath 
hargs hmail man)))
+(eval-and-compile (mapc #'require '(bookmark hvar hsettings comint hbut hpath 
hargs hmail man hsys-org)))
 
 ;;; ************************************************************************
 ;;; Public declarations
@@ -27,6 +27,7 @@
 (declare-function kotl-mode:goto-cell "kotl-mode")
 (declare-function kotl-mode:beginning-of-buffer "kotl-mode")
 (declare-function rmail:msg-to-p "hrmail")
+(declare-function org-roam-id-find "‎ext:org-roam-id")
 
 ;;; ************************************************************************
 ;;; Standard Hyperbole action types
@@ -503,7 +504,7 @@ available.  Filename may be given without the .info suffix."
     (hypb:error "(link-to-Info-node): Invalid Info node: `%s'" string)))
 
 (defact link-to-ibut (name-key &optional but-src point)
-  "Perform implicit button action specified by NAME-KEY, optional BUT-SRC and 
POINT.
+  "Activate implicit button given by NAME-KEY, optional BUT-SRC and POINT.
 NAME-KEY must be a normalized key for an ibut <[name]>.
 BUT-SRC defaults to the current buffer's file or if there is no
 attached file, then to its buffer name.  POINT defaults to the
@@ -612,7 +613,7 @@ See doc of `ibtypes::org-id' for usage."
     (org-mark-ring-push)
     (hact #'link-to-buffer-tmp (marker-buffer marker) marker)
     (move-marker marker nil)
-    (org-show-context))
+    (org-fold-show-context))
 
 (defact link-to-regexp-match (regexp n source &optional buffer-p)
   "Find REGEXP's Nth occurrence in SOURCE and display location at window top.
@@ -739,4 +740,3 @@ Optional SECTIONS-START limits toc entries to those after 
that point."
 (provide 'hactypes)
 
 ;;; hactypes.el ends here
-
diff --git a/hbdata.el b/hbdata.el
index 757bd7ece8..432e31b938 100644
--- a/hbdata.el
+++ b/hbdata.el
@@ -3,7 +3,7 @@
 ;; Author:       Bob Weiner
 ;;
 ;; Orig-Date:     2-Apr-91
-;; Last-Mod:     13-Jun-23 at 01:27:25 by Bob Weiner
+;; Last-Mod:     30-Jun-23 at 22:36:04 by Mats Lidell
 ;;
 ;; SPDX-License-Identifier: GPL-3.0-or-later
 ;;
@@ -288,9 +288,9 @@ class `hbdata' to operate on the entry."
   "Given NAME-KEY, return next ibutton instance number string for current 
buffer.
 If there is no existing ibutton with NAME-KEY, return t.
 
-With NAME-KEY nil or NAME-KEY 'name' and no existing in-buffer ibutton
+With NAME-KEY nil or NAME-KEY `name' and no existing in-buffer ibutton
 with that name, return t.
-With NAME-KEY 'name' and highest in-buffer ibutton 'name:3',
+With NAME-KEY `name' and highest in-buffer ibutton `name:3',
 return ':4'."
   (if (null name-key)
       t
@@ -305,8 +305,8 @@ Instance number is returned as an integer.  Return 1 if 
NAME-KEY exists
 in the buffer but no other instances do; nil if no instance.
 
 With no match, return nil.
-With only 'name' found, return 1.
-With 'name' and 'name:2' found, return 2."
+With only `name' found, return 1.
+With `name' and `name:2' found, return 2."
   (let ((key (car (ibut:label-sort-keys (ibut:label-key-match name-key)))))
     (cond ((null key) nil)
          ((string-match (concat (regexp-quote hbut:instance-sep)
@@ -319,7 +319,7 @@ With 'name' and 'name:2' found, return 2."
   "Return string for the next higher button instance number after NAME-KEY's.
 Return nil if NAME-KEY is nil.
 
-Given 'name', return ':2'.  Given 'name:2', return ':3'.
+Given `name', return ':2'.  Given `name:2', return ':3'.
 
 This does not search any buffer for other instances; it uses the
 NAME-KEY string literally, so it must include any instance number
diff --git a/hbut.el b/hbut.el
index e7d4fd2f92..10a168a7bd 100644
--- a/hbut.el
+++ b/hbut.el
@@ -3,7 +3,7 @@
 ;; Author:       Bob Weiner
 ;;
 ;; Orig-Date:    18-Sep-91 at 02:57:09
-;; Last-Mod:     29-Jun-23 at 17:12:36 by Mats Lidell
+;; Last-Mod:     30-Jun-23 at 22:39:57 by Mats Lidell
 ;;
 ;; SPDX-License-Identifier: GPL-3.0-or-later
 ;;
@@ -1631,7 +1631,7 @@ associated arguments from the button."
          (funcall ibut-type-symbol))))))
 
 (defun    ibut:set-name-and-label-key-p (&optional start-delim end-delim)
-  "Set ibut name, lbl-key, lbl-start/end attributes in 'hbut:current.
+  "Set ibut name, lbl-key, lbl-start/end attributes in \\='hbut:current.
 Point may be on the implicit button text or its optional preceding
 name.  Return t if on a named or delimited text implicit button;
 return nil otherwise.
@@ -1641,8 +1641,8 @@ button text (not name); without these, try a series of 
matching
 delimiters (double quotes, angle brackets, braces and square
 brackets).
 
-This will not set the 'name attribute unless there is a <[name]>
-prefix.  This will not set the 'lbl-key or the 'lbl-end location
+This will not set the \\='name attribute unless there is a <[name]>
+prefix.  This will not set the \\='lbl-key or the \\='lbl-end location
 attribute unless the button text is delimited.
 
 Any implicit button name must contain at least two characters,
@@ -1721,7 +1721,7 @@ if CATEG and following arguments are not given, create 
the button
 object from the implicit button at point, if any; in which case,
 return nil if no implicit button is found at point.
 
-Store new button attributes in the symbol, 'hbut:current."
+Store new button attributes in the symbol, \\='hbut:current."
   ;; :args is ignored unless :categ or :action is also given.
 
   ;; `lbl-key' attribute will be set from `but-sym' if any, the button
diff --git a/hpath.el b/hpath.el
index 55da0c140f..47cd61f2e7 100644
--- a/hpath.el
+++ b/hpath.el
@@ -3,7 +3,7 @@
 ;; Author:       Bob Weiner
 ;;
 ;; Orig-Date:     1-Nov-91 at 00:44:23
-;; Last-Mod:     19-Jun-23 at 14:29:44 by Bob Weiner
+;; Last-Mod:     30-Jun-23 at 22:38:18 by Mats Lidell
 ;;
 ;; SPDX-License-Identifier: GPL-3.0-or-later
 ;;
@@ -2520,7 +2520,7 @@ that returns a replacement string."
   "Replace with VAR-SYMBOL any occurrences of VAR-DIR-VAL in PATH.
 Replacement is done iff VAR-DIR-VAL is an absolute path.
 
-If VAR-SYMBOL is 'hyperb:dir or 'load-path, remove the matching PATH
+If VAR-SYMBOL is \\='hyperb:dir or \\='load-path, remove the matching PATH
 part rather than replacing it with the variable since it can be
 resolved without attaching the variable name.
 
diff --git a/hui.el b/hui.el
index 91a8e42bb1..cf2244135d 100644
--- a/hui.el
+++ b/hui.el
@@ -3,7 +3,7 @@
 ;; Author:       Bob Weiner
 ;;
 ;; Orig-Date:    19-Sep-91 at 21:42:03
-;; Last-Mod:     25-Jun-23 at 09:41:45 by Bob Weiner
+;; Last-Mod:     30-Jun-23 at 22:50:57 by Mats Lidell
 ;;
 ;; SPDX-License-Identifier: GPL-3.0-or-later
 ;;
@@ -664,7 +664,7 @@ When in the global button buffer, the default is the button 
at point."
 
 (defun hui:gibut-create (name text)
   "Create a Hyperbole global implicit button with NAME and button TEXT at 
point.
-Button is stored as the properties of the symbol, 'hbut:current.
+Button is stored as the properties of the symbol, \\='hbut:current.
 
 Use `hui:gbut-create' to create a global explicit button."
   (interactive "sCreate global implicit button named: \nsButton text (with any 
delimiters): ")
diff --git a/kotl/kview.el b/kotl/kview.el
index 6c54f1dd1d..1ca6fcb866 100644
--- a/kotl/kview.el
+++ b/kotl/kview.el
@@ -3,7 +3,7 @@
 ;; Author:       Bob Weiner
 ;;
 ;; Orig-Date:    6/30/93
-;; Last-Mod:     21-Jun-23 at 21:00:17 by Bob Weiner
+;; Last-Mod:     30-Jun-23 at 21:43:29 by Mats Lidell
 ;;
 ;; SPDX-License-Identifier: GPL-3.0-or-later
 ;;
@@ -507,7 +507,7 @@ If between kcells, move to the previous one.  The current 
cell may be hidden."
           ;; only in cases where no 'kcell property is found in cells,
           ;; e.g. before in-memory representation is created.
           (goto-char (- (match-end 0) 2)))
-         (t (error "(kcell-view:to-label-end): In cell at pos %d, can't find 
end of cell's label")))))
+         (t (error "(kcell-view:to-label-end): In cell at pos %d, can't find 
end of cell's label" (or pos (point)))))))
 
 (defun kcell-view:absolute-reference (&optional pos)
   "Return a klink to kcell at optional POS or point; return nil if not in a 
kcell.