[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/denote bd4ac5d806 1/6: Ensure that 'denote-file-prompt'
From: |
ELPA Syncer |
Subject: |
[elpa] externals/denote bd4ac5d806 1/6: Ensure that 'denote-file-prompt' uses its own history |
Date: |
Fri, 31 Mar 2023 12:57:39 -0400 (EDT) |
branch: externals/denote
commit bd4ac5d806036a9ad4880ee035acbf7d76ccfb50
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>
Ensure that 'denote-file-prompt' uses its own history
It used to pollute the 'denote--title-history' with file paths,
whereas that one should only hold strings of file titles.
Thanks to Jonathan Sahar for bringing this matter to my attention.
This was done in issue 144 on the GitHub mirror:
<https://github.com/protesilaos/denote/issues/144>.
---
README.org | 12 ++++++------
denote.el | 5 ++++-
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/README.org b/README.org
index 08ac59be49..7e1bcf9b7d 100644
--- a/README.org
+++ b/README.org
@@ -3954,12 +3954,12 @@ Denote is meant to be a collective effort. Every bit
of help matters.
+ Ideas and/or user feedback :: Abin Simon, Aditya Yadav, Alan
Schmitt, Alfredo Borrás, Benjamin Kästner, Colin McLear, Damien
Cassou, Elias Storms, Federico Stilman, Florian, Frank Ehmsen, Guo
- Yong, Hanspeter Gisler, Jack Baty, Jeremy Friesen, Juanjo Presa,
- Johan Bolmsjö, Kaushal Modi, M. Hadi Timachi, Mirko Hernandez, Paul
- van Gelder, Peter Prevos, Shreyas Ragavan, Stefan Thesing, Summer
- Emacs, Sven Seebeck, Taoufik, Viktor Haag, Yi Liu, Ypot, atanasj,
- doolio, drcxd, hpgisler, pRot0ta1p, rbenit68, relict007, sienic,
- sundar bp.
+ Yong, Hanspeter Gisler, Jack Baty, Jeremy Friesen, Jonathan Sahar,
+ Juanjo Presa, Johan Bolmsjö, Kaushal Modi, M. Hadi Timachi, Mirko
+ Hernandez, Paul van Gelder, Peter Prevos, Shreyas Ragavan, Stefan
+ Thesing, Summer Emacs, Sven Seebeck, Taoufik, Viktor Haag, Yi Liu,
+ Ypot, atanasj, doolio, drcxd, hpgisler, pRot0ta1p, rbenit68,
+ relict007, sienic, sundar bp.
Special thanks to Peter Povinec who helped refine the file-naming
scheme, which is the cornerstone of this project.
diff --git a/denote.el b/denote.el
index 79962849ea..7321959677 100644
--- a/denote.el
+++ b/denote.el
@@ -799,6 +799,9 @@ The path is relative to DIRECTORY (default:
‘default-directory’)."
(dirs (list (project-root project))))
(project-files project dirs)))
+(defvar denote--file-history nil
+ "Minibuffer history of `denote-file-prompt'.")
+
(defun denote-file-prompt (&optional initial-text)
"Prompt for file with identifier in variable `denote-directory'.
With optional INITIAL-TEXT, use it to prepopulate the minibuffer."
@@ -806,7 +809,7 @@ With optional INITIAL-TEXT, use it to prepopulate the
minibuffer."
(completion-ignore-case read-file-name-completion-ignore-case))
(when all-files
(funcall project-read-file-name-function
- "Select note: " all-files nil 'denote--title-history
initial-text))))
+ "Select note: " all-files nil 'denote--file-history
initial-text))))
(define-obsolete-function-alias
'denote--retrieve-read-file-prompt
- [elpa] externals/denote updated (d76bebd71e -> b755832873), ELPA Syncer, 2023/03/31
- [elpa] externals/denote b755832873 6/6: Add links to video demo of Denote, ELPA Syncer, 2023/03/31
- [elpa] externals/denote a4c06fcede 3/6: Fix symbol name in denote-link-or-create docstring, ELPA Syncer, 2023/03/31
- [elpa] externals/denote 2a1d5eb8f6 4/6: Add code to integrate menu with context-menu-mode, ELPA Syncer, 2023/03/31
- [elpa] externals/denote bd4ac5d806 1/6: Ensure that 'denote-file-prompt' uses its own history,
ELPA Syncer <=
- [elpa] externals/denote 64bc2823d2 2/6: Fix symbol name in denote-open-or-create docstring, ELPA Syncer, 2023/03/31
- [elpa] externals/denote ecccc046be 5/6: Document integration with context-menu-mode (also see 2a1d5eb), ELPA Syncer, 2023/03/31