[nongnu] elpa/git-commit dec25b407b: magit-log-set-commit-limit: Modify copy of magit-buffer-log-args

[ELPA Syncer]

branch: elpa/git-commit
commit dec25b407bde4a3406b3491156636e81abd2a754
Author: Kyle Meyer <kyle@kyleam.com>
Commit: Kyle Meyer <kyle@kyleam.com>

    magit-log-set-commit-limit: Modify copy of magit-buffer-log-args
    
    magit-log-set-commit-limit calls `delete' on the magit-buffer-log-args
    value.  This may be the same object as the magit-log-default-arguments
    property.  For example, with the default
    magit-direct-use-buffer-arguments, magit-log-buffer-file passes the
    result of (get 'magit-log-mode 'magit-log-default-arguments) to
    magit-log-setup-buffer.  In that case, calling
    magit-log-set-commit-limit in the resulting log deletes the -nN
    argument from the default log arguments.
    
    Use `remove' instead to avoid modifying magit-log-default-arguments.
    
    Fixes #4898.
---
 lisp/magit-log.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/magit-log.el b/lisp/magit-log.el
index a43b35eea6..fe4fa19c92 100644
--- a/lisp/magit-log.el
+++ b/lisp/magit-log.el
@@ -881,7 +881,7 @@ limit.  Otherwise set it to 256."
          (arg (--first (string-match "^-n\\([0-9]+\\)?$" it) val))
          (num (and arg (string-to-number (match-string 1 arg))))
          (num (if num (funcall fn num 2) 256)))
-    (setq val (delete arg val))
+    (setq val (remove arg val))
     (setq magit-buffer-log-args
           (if (and num (> num 0))
               (cons (format "-n%i" num) val)