emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/embark 8245308630: Use the key custom type for string t


From: ELPA Syncer
Subject: [elpa] externals/embark 8245308630: Use the key custom type for string that must be key-valid-p
Date: Sun, 5 Mar 2023 12:58:04 -0500 (EST)

branch: externals/embark
commit 8245308630948a4e1f0d0539c8939e2831255d43
Author: Omar Antolín Camarena <omar.antolin@gmail.com>
Commit: Omar Antolín Camarena <omar.antolin@gmail.com>

    Use the key custom type for string that must be key-valid-p
    
    This also requires Compat 29.1.4.0, so bump the version there too.
    This fixes #609, thanks to @minad for telling me about the key custom type!
---
 embark.el | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/embark.el b/embark.el
index af326eb36e..edd71051d6 100644
--- a/embark.el
+++ b/embark.el
@@ -7,7 +7,7 @@
 ;; Keywords: convenience
 ;; Version: 0.21.1
 ;; Homepage: https://github.com/oantolin/embark
-;; Package-Requires: ((emacs "27.1") (compat "29.1.3.4"))
+;; Package-Requires: ((emacs "27.1") (compat "29.1.4.0"))
 
 ;; This file is part of GNU Emacs.
 
@@ -236,7 +236,7 @@ prompts for an action with completion."
 
 The key must be either nil or a string.  The
 string must be accepted by `key-valid-p'."
-  :type '(choice string (const :tag "None" nil)))
+  :type '(choice key (const :tag "None" nil)))
 
 (defcustom embark-cycle-key nil
   "Key used for `embark-cycle'.
@@ -244,7 +244,7 @@ string must be accepted by `key-valid-p'."
 If the key is set to nil it defaults to the global binding of
 `embark-act'.  The key must be a string which is accepted by
 `key-valid-p'."
-  :type '(choice string (const :tag "Use embark-act key" nil)))
+  :type '(choice key (const :tag "Use embark-act key" nil)))
 
 (defcustom embark-help-key "C-h"
   "Key used for help.
@@ -254,7 +254,7 @@ string must be accepted by `key-valid-p'."
   :type '(choice (const "C-h")
                  (const "?")
                  (const :tag "None" nil)
-                 string))
+                 key))
 
 (defcustom embark-keybinding-repeat
   (propertize "*" 'face 'embark-keybinding-repeat)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]