emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/cider cf7335baea: Allow "npx nbb" as the cider-nbb-command


From: ELPA Syncer
Subject: [nongnu] elpa/cider cf7335baea: Allow "npx nbb" as the cider-nbb-command
Date: Wed, 4 Jan 2023 08:58:44 -0500 (EST)

branch: elpa/cider
commit cf7335baea9b514d432c173487f0b796db268007
Author: Byron Clark <byron@theclarkfamily.name>
Commit: Bozhidar Batsov <bozhidar@batsov.dev>

    Allow "npx nbb" as the cider-nbb-command
    
    Users of nbb may prefer the version in the project versus the global
    version. Unlike shadow-cljs don't default to the npx command as
    default, but allow the command to function when set as
    `cider-nbb-command`.
---
 CHANGELOG.md | 1 +
 cider.el     | 6 +++++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 056f79a6d9..88feafc5b7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # Changelog
 
 ## master (unreleased)
+- Allow using `npx nbb` as `cider-nbb-command`.
 
 ## 1.6.0 (2022-12-21)
 
diff --git a/cider.el b/cider.el
index 1cbbbe8dc5..64415ae9dc 100644
--- a/cider.el
+++ b/cider.el
@@ -377,12 +377,16 @@ Throws an error if PROJECT-TYPE is unknown."
     ('shadow-cljs (let ((parts (split-string cider-shadow-cljs-command)))
                     (when-let* ((command (cider--resolve-command (car parts))))
                       (mapconcat #'identity (cons command (cdr parts)) " "))))
+    ;; here we have to account for the possibility that the command is either
+    ;; "nbb" (default) or "npx nbb".
+    ('nbb (let ((parts (split-string cider-nbb-command)))
+            (when-let* ((command (cider--resolve-command (car parts))))
+              (mapconcat #'identity (cons command (cdr parts)) " "))))
     ;; here we have to account for use of the Gradle wrapper which is
     ;; a shell script within their project, so if they have a clearly
     ;; relative path like "./gradlew" use locate file instead of checking
     ;; the exec-path
     ('gradle (cider--resolve-project-command cider-gradle-command))
-    ('nbb (cider--resolve-command cider-nbb-command))
     (_ (user-error "Unsupported project type `%S'" project-type))))
 
 (defun cider-jack-in-global-options (project-type)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]