emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/org a526ea6a3e: Fix compiler warnings


From: ELPA Syncer
Subject: [elpa] externals/org a526ea6a3e: Fix compiler warnings
Date: Mon, 19 Sep 2022 23:57:51 -0400 (EDT)

branch: externals/org
commit a526ea6a3e3d94e92a95ee109c8a0064d409816a
Author: Ihor Radchenko <yantar92@gmail.com>
Commit: Ihor Radchenko <yantar92@gmail.com>

    Fix compiler warnings
    
    * lisp/oc-basic.el (org-cite-basic--set-keymap): Do not use
    `buffer-substring' generalized variable.  It is obsolete in Emacs 29.
    Explicitly call `delete-region' + `insert'.
    * lisp/org-agenda.el (org-element-lineage): Declare function.
    * lisp/org.el (org--align-node-property): Use `delete-region' instead
    of `buffer-substring' generalized variable.
---
 lisp/oc-basic.el   | 15 +++++++++------
 lisp/org-agenda.el |  2 ++
 lisp/org.el        |  2 +-
 3 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/lisp/oc-basic.el b/lisp/oc-basic.el
index 07f9b39d1f..f1b7c8263c 100644
--- a/lisp/oc-basic.el
+++ b/lisp/oc-basic.el
@@ -502,12 +502,15 @@ substitutes for the unknown key.  Finally, it may be the 
symbol
         (_
          (lambda ()
            (interactive)
-           (setf (buffer-substring beg end)
-                 (concat "@"
-                         (if (= 1 (length suggestions))
-                             (car suggestions)
-                           (completing-read "Did you mean: "
-                                            suggestions nil t))))))))
+           (save-excursion
+             (goto-char beg)
+             (delete-region beg end)
+             (insert
+              "@"
+              (if (= 1 (length suggestions))
+                  (car suggestions)
+                (completing-read "Did you mean: "
+                                 suggestions nil t))))))))
     (put-text-property beg end 'keymap km)))
 
 (defun org-cite-basic-activate (citation)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index a661f182b3..4ab6d35aa2 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -83,6 +83,8 @@
 (declare-function org-element-property "org-element" (property element))
 (declare-function org-element--cache-active-p "org-element"
                   (&optional called-from-cache-change-func-p))
+(declare-function org-element-lineage "org-element"
+                  (datum &optional types with-self))
 (declare-function org-habit-insert-consistency-graphs
                  "org-habit" (&optional line))
 (declare-function org-is-habit-p "org-habit" (&optional pom))
diff --git a/lisp/org.el b/lisp/org.el
index 3bb34256ab..a509215198 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -18695,7 +18695,7 @@ Alignment is done according to `org-property-format', 
which see."
                              (format org-property-format (match-string 1) 
(match-string 3))))))
         ;; Do not use `replace-match' here as we want to inherit folding
         ;; properties if inside fold.
-        (setf (buffer-substring (match-beginning 0) (match-end 0)) "")
+        (delete-region (match-beginning 0) (match-end 0))
         (insert-and-inherit newtext)))))
 
 (defun org-indent-line ()



reply via email to

[Prev in Thread] Current Thread [Next in Thread]