emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/git-commit 4ee691cd90: magit-commit-diff-1: Fix display bu


From: ELPA Syncer
Subject: [nongnu] elpa/git-commit 4ee691cd90: magit-commit-diff-1: Fix display buffer action alist syntax
Date: Mon, 19 Sep 2022 09:58:46 -0400 (EDT)

branch: elpa/git-commit
commit 4ee691cd90a4975b31ba4f3f6fc3ae69a0b0eb62
Author: Basil L. Contovounesios <contovob@tcd.ie>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    magit-commit-diff-1: Fix display buffer action alist syntax
    
    Technically (t) and t are equally valid non-nil values for the
    `inhibit-same-window' display buffer action alist entry, but to
    minimize confusion and proliferation of future mistakes, use the
    simpler and more widespread boolean.
---
 lisp/magit-commit.el | 2 +-
 lisp/magit-diff.el   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/magit-commit.el b/lisp/magit-commit.el
index 98f9764600..fef4eaf2f4 100644
--- a/lisp/magit-commit.el
+++ b/lisp/magit-commit.el
@@ -613,7 +613,7 @@ See `magit-commit-absorb' for an alternative 
implementation."
              display-buffer-overriding-action))
         (when magit-commit-diff-inhibit-same-window
           (setq display-buffer-overriding-action
-                '(nil (inhibit-same-window t))))
+                '(nil (inhibit-same-window . t))))
         (magit-diff-setup-buffer rev arg (car (magit-diff-arguments)) nil)))))
 
 (add-hook 'server-switch-hook #'magit-commit-diff)
diff --git a/lisp/magit-diff.el b/lisp/magit-diff.el
index cf0fb220b0..c9d9e803d0 100644
--- a/lisp/magit-diff.el
+++ b/lisp/magit-diff.el
@@ -1604,7 +1604,7 @@ the Magit-Status buffer for DIRECTORY."
       (dired-jump other-window (concat directory "/."))
     (let ((display-buffer-overriding-action
            (if other-window
-               '(nil (inhibit-same-window t))
+               '(nil (inhibit-same-window . t))
              '(display-buffer-same-window))))
       (magit-status-setup-buffer directory))))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]