emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/ef-themes b8ea1360d8: Simplify ef-themes-collection (th


From: ELPA Syncer
Subject: [elpa] externals/ef-themes b8ea1360d8: Simplify ef-themes-collection (thanks Philip Kaludercic)
Date: Sat, 17 Sep 2022 09:57:34 -0400 (EDT)

branch: externals/ef-themes
commit b8ea1360d841f6c1274d13fac75dfa5fc2cb14bb
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Simplify ef-themes-collection (thanks Philip Kaludercic)
    
    Thanks to Philip for suggesting the use of 'seq-union' over at the
    emacs-devel mailing list:
    <https://lists.gnu.org/archive/html/emacs-devel/2022-09/msg01053.html>.
    
    I could not use 'seq-union' because it introduces a dependency on Emacs
    28.  I went with 'append' instead.
---
 ef-themes.el | 24 ++++--------------------
 1 file changed, 4 insertions(+), 20 deletions(-)

diff --git a/ef-themes.el b/ef-themes.el
index 0a6b04e59a..c539a6360c 100644
--- a/ef-themes.el
+++ b/ef-themes.el
@@ -48,26 +48,6 @@
 
 ;;; User options
 
-;; FIXME 2022-09-16: Maybe the `ef-themes-collection' should just
-;; combine the `ef-themes-light-themes' and `ef-themes-dark-themes'?
-;; This duplication seems unnecessary.
-(defconst ef-themes-collection
-  '(ef-autumn
-    ef-dark
-    ef-day
-    ef-deuteranopia-dark
-    ef-deuteranopia-light
-    ef-duo-dark
-    ef-duo-light
-    ef-light
-    ef-night
-    ef-spring
-    ef-summer
-    ef-trio-dark
-    ef-trio-light
-    ef-winter)
-  "Symbols of all the Ef themes.")
-
 (defconst ef-themes-light-themes
   '(ef-day ef-deuteranopia-light ef-duo-light ef-light ef-spring ef-summer 
ef-trio-light)
   "List of symbols with the light Ef themes.")
@@ -76,6 +56,10 @@
   '(ef-autumn ef-dark ef-deuteranopia-dark ef-duo-dark ef-night ef-trio-dark 
ef-winter)
   "List of symbols with the dark Ef themes.")
 
+(defconst ef-themes-collection
+  (append ef-themes-light-themes ef-themes-dark-themes)
+  "Symbols of all the Ef themes.")
+
 (defcustom ef-themes-post-load-hook nil
   "Hook that runs after loading an Ef theme.
 This is used by the commands `ef-themes-select' and



reply via email to

[Prev in Thread] Current Thread [Next in Thread]