emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/embark 476f2ae8cd 2/3: Fix bugs found in PR #542


From: ELPA Syncer
Subject: [elpa] externals/embark 476f2ae8cd 2/3: Fix bugs found in PR #542
Date: Fri, 16 Sep 2022 09:57:43 -0400 (EDT)

branch: externals/embark
commit 476f2ae8cd9ff2bb1f819352ef32d0aace77be48
Author: Omar Antolín <omar.antolin@gmail.com>
Commit: Omar Antolín <omar.antolin@gmail.com>

    Fix bugs found in PR #542
    
    - Use a better test for whether the user is in a completion session in
    embark-target-top-minibuffer-completion.
    - Use type general instead of nil.
---
 embark.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/embark.el b/embark.el
index 7b520fdcc9..78bf4df09a 100644
--- a/embark.el
+++ b/embark.el
@@ -842,7 +842,7 @@ completion UI highly compatible with it, like Icomplete.
 Many completion UIs can still work with Embark but will need
 their own target finder.  See for example
 `embark--vertico-selected' or `embark--selectrum-selected'."
-  (when (minibufferp)
+  (when (and (minibufferp) minibuffer-completion-table)
     (pcase-let* ((`(,category . ,candidates) (embark-minibuffer-candidates))
                  (contents (minibuffer-contents))
                  (top (if (test-completion contents
@@ -1971,7 +1971,7 @@ plist concerns one target, and has keys `:type', 
`:target',
      'embark-target-finders
      (lambda (fun)
        (when-let (found (funcall fun))
-         (let* ((type (car found))
+         (let* ((type (or (car found) 'general))
                 (target+bounds (cdr found))
                 (target (if (consp target+bounds)
                             (car target+bounds)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]