[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/denote 8c11c5867d 5/6: Make denote-file-is-writable-and
From: |
ELPA Syncer |
Subject: |
[elpa] externals/denote 8c11c5867d 5/6: Make denote-file-is-writable-and-supported-p public |
Date: |
Wed, 14 Sep 2022 04:57:32 -0400 (EDT) |
branch: externals/denote
commit 8c11c5867dca34378bb91d63fc0e4e62ee91584c
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>
Make denote-file-is-writable-and-supported-p public
We are working towards version 1.0.0. The idea is to provide functions
that users/developers can rely on. By making them public (removing the
double hyphens) we signify that those forms are (i) in a stable
state, and (ii) any change to them will be handled with care and
documented accordingly.
---
README.org | 3 +++
denote.el | 19 ++++++++++++-------
2 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/README.org b/README.org
index a5fcfdf44b..b6b1fc52ae 100644
--- a/README.org
+++ b/README.org
@@ -2029,6 +2029,9 @@ might change them without further notice.
=.gpg= suffix. Supported extensions are those implied by
~denote-file-type~.
++ ~denote-file-is-writable-and-supported-p~ :: Return non-nil if =FILE=
+ is writable and has supported extension.
+
+ ~denote-directory-files~ :: List absolute file paths in variable
~denote-directory~. The returned files only need to have an
identifier. This may include files that are not implied by
diff --git a/denote.el b/denote.el
index 71c7f63162..acfbd2b6f1 100644
--- a/denote.el
+++ b/denote.el
@@ -513,11 +513,16 @@ Supported extensions are those implied by
`denote-file-type'."
(and (file-regular-p file)
(file-writable-p file)))
-(defun denote--writable-and-supported-p (file)
+(defun denote-file-is-writable-and-supported-p (file)
"Return non-nil if FILE is writable and has supported extension."
(and (denote--file-regular-writable-p file)
(denote-file-has-supported-extension-p file)))
+(define-obsolete-function-alias
+ 'denote--writable-and-supported-p
+ 'denote-file-is-writable-and-supported-p
+ "1.0.0")
+
(defun denote--file-name-relative-to-denote-directory (file)
"Return name of FILE relative to the variable `denote-directory'.
FILE must be an absolute path."
@@ -1707,7 +1712,7 @@ files)."
(when (denote-rename-file-prompt file new-name)
(denote-rename-file-and-buffer file new-name)
(denote-update-dired-buffers)
- (when (denote--writable-and-supported-p new-name)
+ (when (denote-file-is-writable-and-supported-p new-name)
(if (denote--edit-front-matter-p new-name file-type)
(denote--rewrite-front-matter new-name title keywords file-type)
(denote--add-front-matter new-name title keywords id file-type))))))
@@ -1769,7 +1774,7 @@ The operation does the following:
(new-name (denote-format-file-name
dir id keywords (denote-sluggify title)
extension)))
(denote-rename-file-and-buffer file new-name)
- (when (denote--writable-and-supported-p new-name)
+ (when (denote-file-is-writable-and-supported-p new-name)
(if (denote--edit-front-matter-p new-name file-type)
(denote--rewrite-keywords new-name keywords file-type)
(denote--add-front-matter new-name title keywords id
file-type)))))
@@ -1802,7 +1807,7 @@ typos and the like."
(if (y-or-n-p "Would you like to save the buffer?")
(save-buffer)
(user-error "Save buffer before proceeding")))
- (unless (denote--writable-and-supported-p file)
+ (unless (denote-file-is-writable-and-supported-p file)
(user-error "The file is not writable or does not have a supported file
extension"))
(if-let* ((file-type (denote-filetype-heuristics file))
(title (denote-retrieve-title-value file file-type))
@@ -1849,7 +1854,7 @@ This command is useful for synchronizing multiple file
names with
their respective front matter."
(interactive nil dired-mode)
(if-let ((marks (seq-filter
- #'denote--writable-and-supported-p
+ #'denote-file-is-writable-and-supported-p
(dired-get-marked-files))))
(progn
(dolist (file marks)
@@ -1901,7 +1906,7 @@ relevant front matter."
(buffer-file-name)
(denote-title-prompt)
(denote-keywords-prompt)))
- (when (denote--writable-and-supported-p file)
+ (when (denote-file-is-writable-and-supported-p file)
(denote--add-front-matter
file title keywords
(denote-retrieve-or-create-file-identifier file)
@@ -2406,7 +2411,7 @@ option `denote-link-backlinks-display-buffer-action'. By
default, it will show up below the current window."
(interactive)
(let ((file (buffer-file-name)))
- (when (denote--writable-and-supported-p file)
+ (when (denote-file-is-writable-and-supported-p file)
(let* ((id (denote-retrieve-filename-identifier file))
(file-type (denote-filetype-heuristics file))
(title (denote-retrieve-title-value file file-type)))
- [elpa] externals/denote updated (ea0f50575e -> fb92d22a57), ELPA Syncer, 2022/09/14
- [elpa] externals/denote 46e207a2cd 4/6: Fix typo in doc string, ELPA Syncer, 2022/09/14
- [elpa] externals/denote dbdf8f58f2 1/6: Make denote-file-is-note-p public, ELPA Syncer, 2022/09/14
- [elpa] externals/denote d6b0355483 2/6: Fix typo in the manual, ELPA Syncer, 2022/09/14
- [elpa] externals/denote 88c396e0bb 3/6: Make two file/note predicates public, ELPA Syncer, 2022/09/14
- [elpa] externals/denote 8c11c5867d 5/6: Make denote-file-is-writable-and-supported-p public,
ELPA Syncer <=
- [elpa] externals/denote fb92d22a57 6/6: Make denote-file-name-relative-to-denote-directory public, ELPA Syncer, 2022/09/14