emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/org c3d6672cfd 5/6: ol.el: Avoid links like "[[target][


From: ELPA Syncer
Subject: [elpa] externals/org c3d6672cfd 5/6: ol.el: Avoid links like "[[target][file:~/org/test.org::target]]"
Date: Tue, 13 Sep 2022 09:58:03 -0400 (EDT)

branch: externals/org
commit c3d6672cfdbff8c9dd4c2ec70886ad3f62153d07
Author: Max Nikulin <manikulin@gmail.com>
Commit: Ihor Radchenko <yantar92@gmail.com>

    ol.el: Avoid links like "[[target][file:~/org/test.org::target]]"
    
    * lisp/ol.el (org-store-link): Do not set description for "<<target>>"
    links to avoid case when it is more detailed than link target.
    
    While inserting to the same file, file part of the link target is
    stripped, description is inserted without modification.  I do not think,
    file path adds real value in comparison to "[[target]]" link to some
    point in the same file.  A side effect is user prompt for description
    since link and description are not identical any more.
---
 lisp/ol.el | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/lisp/ol.el b/lisp/ol.el
index eacc69deb2..b97af3dbc8 100644
--- a/lisp/ol.el
+++ b/lisp/ol.el
@@ -1663,12 +1663,17 @@ non-nil."
         (cond
          ;; Store a link using the target at point
          ((org-in-regexp "[^<]<<\\([^<>]+\\)>>[^>]" 1)
-          (setq cpltxt
+          (setq link
                 (concat "file:"
                         (abbreviate-file-name
                          (buffer-file-name (buffer-base-buffer)))
                         "::" (match-string 1))
-                link cpltxt
+                 ;; Target may be shortened when link is inserted.
+                 ;; Avoid [[target][file:~/org/test.org::target]]
+                 ;; links.  Maybe the case of identical target and
+                 ;; description should be handled by `org-insert-link'.
+                 cpltxt nil
+                 desc nil
                  ;; Do not append #CUSTOM_ID link below.
                  custom-id nil))
          ((and (featurep 'org-id)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]