emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/ement f7cd7a857b: Fix: (ement-room-start-read-receipt-t


From: ELPA Syncer
Subject: [elpa] externals/ement f7cd7a857b: Fix: (ement-room-start-read-receipt-timer) Temporarily disable
Date: Sun, 11 Sep 2022 10:57:35 -0400 (EDT)

branch: externals/ement
commit f7cd7a857be7c60af1c01c4dc1cc2a68d78b25ce
Author: Adam Porter <adam@alphapapa.net>
Commit: Adam Porter <adam@alphapapa.net>

    Fix: (ement-room-start-read-receipt-timer) Temporarily disable
    
    A bug was introduced in the previous fixes that can cause excessive
    read receipts to be sent in rapid succession.  A more thoughtful fix
    will be necessary to properly send only one receipt per room event and
    per scroll event.  In the meantime, this must be disabled to prevent
    the excessive network requests.
---
 ement-room.el | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/ement-room.el b/ement-room.el
index 112dc066a0..96af010f33 100644
--- a/ement-room.el
+++ b/ement-room.el
@@ -2451,8 +2451,12 @@ WINDOW's end is beyond the marker.  For use in
       ;; short time.
       (let ((room-buffer (window-buffer window)))
         (setf ement-room-read-receipt-timer
-              (run-with-idle-timer
-               3 nil #'ement-room-read-receipt-timer window room-buffer))))))
+              ;; FIXME: Temporarily disabling sending of read receipts due to 
a bug that
+              ;; can cause excessive read receipts to be sent in rapid 
succession.
+              nil
+              ;; (run-with-idle-timer
+              ;;  3 nil #'ement-room-read-receipt-timer window room-buffer)
+              )))))
 
 (defun ement-room-read-receipt-timer (window room-buffer)
   "Send read receipt for WINDOW displaying ROOM-BUFFER.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]