[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/org-contacts b1032119a3 152/154: Fix package-lint warni
From: |
ELPA Syncer |
Subject: |
[elpa] externals/org-contacts b1032119a3 152/154: Fix package-lint warnings. |
Date: |
Fri, 9 Sep 2022 15:58:56 -0400 (EDT) |
branch: externals/org-contacts
commit b1032119a36b6b9a14b2df50feb9cff7cf042997
Author: stardiviner <numbchild@gmail.com>
Commit: stardiviner <numbchild@gmail.com>
Fix package-lint warnings.
9:67: error: Package gnus is not installable.
9:80: warning: An explicit dependency on cl-lib <= 1.0 is not needed on
Emacs >= 24.3.
634:0: warning: Private functions generally should not be autoloaded.
641:0: warning: Private functions generally should not be autoloaded.
645:19: error: You should depend on (emacs "25.1") or the seq package if
you need `seq-find'.
673:9: error: You should depend on (emacs "27.1") if you need
`org-show-all'.
674:9: error: You should depend on (emacs "25.1") if you need
`font-lock-ensure'.
680:0: warning: Private functions generally should not be autoloaded.
684:19: error: You should depend on (emacs "25.1") or the seq package if
you need `seq-find'.
699:3: error: You should depend on (emacs "26.1") if you need `when-let*'.
766:8: warning: Closing parens should not be wrapped onto new lines.
788:0: error: "org-completing-read-date" doesn't start with package's
prefix "org-contacts".
988:13: error: You should depend on (emacs "25.1") if you need `if-let'.
1060:0: error: "erc-nicknames-list" doesn't start with package's prefix
"org-contacts".
1290:0: warning: Private functions generally should not be autoloaded.
---
org-contacts.el | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/org-contacts.el b/org-contacts.el
index 1aa8dcab64..c11426b4e9 100644
--- a/org-contacts.el
+++ b/org-contacts.el
@@ -1,4 +1,4 @@
-;;; org-contacts.el --- Contacts management system for Org Mode. -*-
lexical-binding: t; -*-
+;;; org-contacts.el --- Contacts management system for Org Mode -*-
lexical-binding: t; -*-
;; Copyright (C) 2010-2014, 2021 Julien Danjou <julien@danjou.info>
@@ -7,6 +7,7 @@
;; Keywords: contacts, org-mode, outlines, hypermedia, calendar
;; Version: 1.0
;; Package-Requires: ((emacs "28.1") (cl-lib "1.0") (org "9.3.4") (gnus
"5.13"))
+;; Homepage: https://repo.or.cz/org-contacts.git
;;
;; This file is not part of GNU Emacs.
;;
@@ -630,14 +631,12 @@ description."
(run-hook-with-args-until-success
'org-contacts-complete-functions string))))))))
-;;;###autoload
(defun org-contacts-org-complete--annotation-function (candidate)
"Return org-contacts tags of contact candidate."
;; TODO
"Tags: "
(ignore candidate))
-;;;###autoload
(defun org-contacts-org-complete--doc-function (candidate)
"Return org-contacts content of contact candidate."
(let* ((candidate (substring-no-properties candidate 1 nil))
@@ -676,7 +675,6 @@ description."
;;; display company-mode doc buffer bellow current window.
(add-to-list 'display-buffer-alist '("^ \\*org-contact\\*" .
(display-buffer-below-selected)))
-;;;###autoload
(defun org-contacts-org-complete--location-function (candidate)
"Return org-contacts location of contact candidate."
(let* ((candidate (substring-no-properties candidate 1 nil))
@@ -761,8 +759,7 @@ Format is a string matching the following format
specification:
%l - Link to the heading
%y - Number of year
%Y - Number of year (ordinal)"
- (let ((calendar-date-style 'american)
- ) ;; (entry "")
+ (let ((calendar-date-style 'american))
(unless format (setq format org-contacts-birthday-format))
(cl-loop for contact in (org-contacts-filter)
for anniv = (let ((anniv (cdr (assoc-string
@@ -784,7 +781,7 @@ Format is a string matching the following format
specification:
(calendar-extract-year anniv))))
(format "%d%s" years
(diary-ordinal-suffix years)))))))))
-(defun org-completing-read-date ( prompt _collection
+(defun org-contacts--completing-read-date ( prompt _collection
&optional _predicate _require-match
_initial-input
_hist def _inherit-input-method)
"Like `completing-read' but reads a date.
@@ -792,7 +789,7 @@ Only PROMPT and DEF are really used."
(org-read-date nil nil nil prompt nil def))
(add-to-list 'org-property-set-functions-alist
- `(,org-contacts-birthday-property . org-completing-read-date))
+ `(,org-contacts-birthday-property .
org-contacts--completing-read-date))
(defun org-contacts-template-name (&optional return-value)
"Try to return the contact name for a template.
@@ -1051,12 +1048,12 @@ address."
hist def
inherit-input-method)
"Like `completing-read' but reads a nickname."
(if (featurep 'erc)
- (org-completing-read prompt (append collection (erc-nicknames-list))
predicate require-match
+ (org-completing-read prompt (append collection
(org-contacts-erc-nicknames-list)) predicate require-match
initial-input hist def inherit-input-method)
(org-completing-read prompt collection predicate require-match
initial-input hist def inherit-input-method)))
-(defun erc-nicknames-list ()
+(defun org-contacts-erc-nicknames-list ()
"Return all nicknames of all ERC buffers."
(cl-loop for buffer in (erc-buffer-list)
nconc (with-current-buffer buffer
@@ -1286,7 +1283,6 @@ are effectively trimmed). If nil, all zero-length
substrings are retained."
(org-link-add-props :link link :description headline-str)
link)))))
-;;;###autoload
(defun org-contacts--all-contacts ()
"Return a list of all contacts in `org-contacts-files'.
Each element has the form (NAME . (FILE . POSITION))."
- [elpa] externals/org-contacts 2e77024e89 017/154: Copyright year fixes for contrib/., (continued)
- [elpa] externals/org-contacts 2e77024e89 017/154: Copyright year fixes for contrib/., ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts 4170ea25f3 090/154: Deprecate `org-find-if' in favor of `cl-find-if', ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts c1a17bf632 076/154: Merge branch 'maint', ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts 2de057e423 145/154: Make org-link-set-parameters <- org-add-link-type API compatible., ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts 21d4ae5367 141/154: Improve the alternative org-contacts headline goto., ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts c1c4cadf3f 151/154: Fix Warning: Unused lexical argument, ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts a50ced61ef 093/154: Update tel link definition, ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts f02da8b4de 088/154: org-contacts: Register "tel" link, ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts 80ab4708b7 114/154: Change how completion is done, ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts 1b028de47c 124/154: Fix contacts complete not working problem, ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts b1032119a3 152/154: Fix package-lint warnings.,
ELPA Syncer <=
- [elpa] externals/org-contacts d1298f4599 083/154: org-contacts.el: Catch `nextfile' in `org-contacts-db', ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts 0a91557ef9 115/154: Tidy up whitespace, ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts 00560d5f4f 117/154: Try to support different type of AVATAR property., ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts 81d9ed977d 138/154: Ensure font-lock after org-mode in company-mode doc-buffer, ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts 8f008e1b70 131/154: Fix company-mode doc-buffer support with reverse query contact element in all contacts list., ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts c8408cf44e 118/154: replace gnus-rescale-image with create-image property :height, ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts 5d0ecac118 143/154: Update package description., ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts 8078958995 082/154: contrib: Fix error messages., ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts 60339bd55f 087/154: Make `org-make-tags-matcher' lexical binding friendly, ELPA Syncer, 2022/09/09
- [elpa] externals/org-contacts 74019274c0 110/154: Update copyright years, ELPA Syncer, 2022/09/09