[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/denote 2ca1223c7b 2/2: Add TODO for denote-link-buttoni
From: |
ELPA Syncer |
Subject: |
[elpa] externals/denote 2ca1223c7b 2/2: Add TODO for denote-link-buttonize-buffer conditionality |
Date: |
Mon, 5 Sep 2022 08:57:30 -0400 (EDT) |
branch: externals/denote
commit 2ca1223c7b98f1144afc36911e8ae7de489aabd3
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>
Add TODO for denote-link-buttonize-buffer conditionality
---
denote.el | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/denote.el b/denote.el
index bc2430deb1..c76430305f 100644
--- a/denote.el
+++ b/denote.el
@@ -2129,6 +2129,12 @@ this.
When called from Lisp, with optional BEG and END as buffer
positions, limit the process to the region in-between."
(interactive)
+ ;; TODO 2022-09-05: Perhaps we need a more relaxed check that does not
+ ;; account for the `denote-directory' instead of
+ ;; `denote--current-file-is-note-p'? For the use-case, see commit
+ ;; a3cc59a. Basically, a 'denote:' link will work for as long as the
+ ;; target file is in the `denote-directory'. So why not buttonize
+ ;; those links even from outside the `denote-directory'?
(when (and (not (derived-mode-p 'org-mode)) (denote--current-file-is-note-p))
(save-excursion
(goto-char (or beg (point-min)))